WordPress.org
Get WordPress

Make WordPress Core

Opened 17 years ago

Closed 16 years ago

#10746 closed defect (bug) (fixed)

wp_count_terms() should call get_terms()

Reported by: scribu Owned by: dd32
Priority: normal Milestone: 3.0
Component: Taxonomy Version: 2.8.4
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

Currently, wp_count_terms() only accepts one argument: 'ignore_empty'.

get_terms() has alot more, so why not use it to also count the terms?

As a direct benefit, we can correct the pagination in wp-admin/edit-tags.php?s=something which ignores the search parameter.

Attachments (2)

wp_count_terms.diff​ (3.3 KB ) - added by scribu 17 years ago.
wp_count_terms.2.diff​ (3.8 KB ) - added by scribu 16 years ago.
refresh

Download all attachments as: .zip

Change History (8)

@scribu
17 years ago

#1 @ryan
17 years ago

  • Milestone 2.9 → 3.0

Seems okay for 3.0.

#2 @scribu
16 years ago

  • Keywords commit added

#3 @scribu
16 years ago

  • Keywords needs-patch added; has-patch commit removed

Ups... patch got stale.

@scribu
16 years ago

refresh

#4 @scribu
16 years ago

  • Keywords has-patch commit added; needs-patch removed

Refreshed patch: wp_count_terms.2.diff

#5 @dd32
16 years ago

  • Owner changed from filosofo to dd32
  • Status new → reviewing

#6 @dd32
16 years ago

  • Resolution → fixed
  • Status reviewing → closed

(In [13491]) Use get_terms() in wp_count_terms(). Props scribu. Fixes #10746

Note: See TracTickets for help on using tickets.