Make WordPress Core

Opened 11 years ago

Closed 9 years ago

Last modified 2 months ago

#1076 closed defect (bug) (fixed)

is_seach logic in default theme which has search.php template

Reported by: MC_incubus Owned by: mdawaffe
Milestone: 2.1 Priority: normal
Severity: trivial Version: 1.5
Component: Template Keywords: has-patch commit template
Focuses: Cc:


in the default 1.5 (kubrick) theme, in the archives.php template, there is this:

<?php /* If this is a search */ } elseif (is_search()) { ?>

<h2 class="pagetitle">Search Results</h2>

But because there is a search.php template, all is_search() true requests should go there, so this logic does nothing in archives.php

Hat tip to dmclark in #wordpress for finding this

Attachments (1)

1076.diff (737 bytes) - added by mdawaffe 9 years ago.

Download all attachments as: .zip

Change History (5)

#1 @MC_incubus
11 years ago

  • Patch set to No

9 years ago

#2 @mdawaffe
9 years ago

  • Keywords has-patch commit template added
  • Milestone set to 2.1
  • Owner changed from anonymous to mdawaffe
  • Status changed from new to assigned


#3 @ryan
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4166]) Remove is_search() check that will never be reached. fixes #1076

This ticket was mentioned in Slack in #polyglots by iandunn. View the logs.

2 months ago

Note: See TracTickets for help on using tickets.