Make WordPress Core

Opened 22 years ago

Closed 20 years ago

Last modified 11 years ago

#1076 closed defect (bug) (fixed)

is_seach logic in default theme which has search.php template

Reported by: MC_incubus Owned by: mdawaffe
Priority: normal Milestone: 2.1
Component: Template Version: 1.5
Severity: trivial Keywords: has-patch commit template
Cc: Focuses:

Description

in the default 1.5 (kubrick) theme, in the archives.php template, there is this:

<?php /* If this is a search */ } elseif (is_search()) { ?>

<h2 class="pagetitle">Search Results</h2>

But because there is a search.php template, all is_search() true requests should go there, so this logic does nothing in archives.php

Hat tip to dmclark in #wordpress for finding this

Attachments (1)

1076.diff (737 bytes ) - added by mdawaffe 20 years ago.

Download all attachments as: .zip

Change History (5)

#1 @MC_incubus
22 years ago

  • PatchNo

@mdawaffe
20 years ago

#2 @mdawaffe
20 years ago

  • Keywords has-patch commit template added
  • Milestone2.1
  • Owner changed from anonymous to mdawaffe
  • Status newassigned

Patched.

#3 @ryan
20 years ago

  • Resolutionfixed
  • Status assignedclosed

(In [4166]) Remove is_search() check that will never be reached. fixes #1076

This ticket was mentioned in Slack in #polyglots by iandunn. View the logs.


11 years ago

Note: See TracTickets for help on using tickets.