Plugin/Theme installer: Do not bail if empty destination directory exists

[dd32]

At present, If you attempt to install a plugin or theme, and the destination directory already exists (Say from a failed upgrade), Then the installer will bail.

Patch adds a check to simply use the folder if it exists AND is empty.

However, It still counts hidden files as being a item in a directory, so if a .svn folder or .htaccess file exists in the folder, the installer will bail. - Any thoughts on that? Should it continue if there are only hidden files? I'm thinking not at present.

[dd32]

However, It still counts hidden files as being a item in a directory, so if a .svn folder or .htaccess file exists in the folder, the installer will bail.

Note that such a case would exist from a failed upgrade due to #10774 - It shouldnt happen in the future.. or it'd only be from a upgrade that failed 70% through..

[azaozz]

(In [11926]) Plugin/Theme installer: Do not bail if empty destination directory exists, props dd32, fixes #10775

[azaozz]

Changed the logic a bit, no need to clear_destination when it doesn't exist.

[dd32]

Changed the logic a bit, no need to clear_destination when it doesn't exist.

Very good point, Looks good to me.