WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#10777 closed defect (bug) (fixed)

PclZip: Upgrade to 2.8.2

Reported by: dd32 Owned by: westi
Milestone: 2.9 Priority: low
Severity: minor Version: 2.9
Component: Upgrade/Install Keywords: needs-patch
Focuses: Cc:

Description (last modified by dd32)

This is a low priority update, Very little has changed, Except it replaces any ereg use with preg usage. I dont think WordPress core triggers the ereg usage however anyway.

I've kept the WordPress modifications to the file (64bit OS bug fix which is still not included in the distribution).

Other than that, The trace comments are removed for a slightly smaller filesize.

Mainly submitting this to keep externals up to date.


2.8.2 was released, See comment below.

Attachments (1)

10777.diff (183.8 KB) - added by dd32 5 years ago.

Download all attachments as: .zip

Change History (6)

dd325 years ago

comment:1 westi5 years ago

  • Owner set to westi
  • Status changed from new to reviewing

comment:2 westi5 years ago

Thanks for this.

Currently working with upstream to get our 64bit change merged and some other improvements done for #10650

Will wait for that for now and just do one change.

comment:3 dd325 years ago

Will wait for that for now and just do one change.

As i just found out, I emailed Vincent possible changes for the eval use, To find out you've already done so (Along with a potential other bug)

Agreed, Wait for the upstream changes and commit in one sweep.

comment:4 dd325 years ago

  • Description modified (diff)
  • Keywords needs-patch added; has-patch removed
  • Summary changed from PclZip: Upgrade to 2.8.1 to PclZip: Upgrade to 2.8.2

2.8.2 has now been released: http://www.phpconcept.net/pclzip/index.en.php#nouveautes_2_8_2

Version 2.8.2 :

  • PCLZIP_CB_PRE_EXTRACT and PCLZIP_CB_POST_EXTRACT are now supported with extraction as a string (PCLZIP_OPT_EXTRACT_AS_STRING). The string can also be modified in the post-extract call back.

Bugs correction

  • PCLZIP_OPT_REMOVE_ALL_PATH was not working correctly
  • Remove use of eval() and do direct call to callback functions
  • Correct support of 64bits systems (Thanks to WordPress team)

comment:5 westi5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

(In [11993]) Update pclzip to 2.8.2 - Fixes #10650 and #10777.
Includes:

  • Removal of eval()s
  • Merge WordPress 64 bit fix upstream
Note: See TracTickets for help on using tickets.