WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#10842 closed defect (bug) (wontfix)

Redundant city name entry for timezone selection

Reported by: hudatoriq Owned by: nbachiyski
Milestone: Priority: low
Severity: normal Version:
Component: I18N Keywords:
Focuses: Cc:

Description

There are two cities inside continents-cities.php file that refer to a single city. 'Ujung Pandang' is the old name of 'Makassar'.

The timezone database used by PHP still consider both Asia/Makassar & Asia/Ujung_Pandang as valid timezone strings. But if we use the city list as an interface, it's better to merge them. Let's only use one of the timezone string.

This page states 'Makassar is also known as Ujung Pandang'
http://www.timeanddate.com/worldclock/city.html?n=653

'Ujung Pandang' on wikipedia redirects to 'Makassar'
http://en.wikipedia.org/wiki/Ujung_Pandang

Attachments (1)

continents-cities.php.diff (469 bytes) - added by hudatoriq 5 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 nacin4 years ago

  • Keywords has-patch added

comment:2 nbachiyski4 years ago

  • Milestone changed from 2.9 to Future Release
  • Priority changed from normal to low

Your patch won't leave out the string. It just will disable its translation.

If you really want to remove the string, you have to patch wp_timezone_choice().

I don't see the point in removing old names of cities. Is it really important? Aren't there any people who know it under its old name?

comment:3 Otto424 years ago

  • Keywords has-patch removed
  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version 2.9 deleted

The timezone cities list comes directly from your PHP installation, not WordPress. If you want an up-to-date list, you need to upgrade your PHP installation.

comment:4 hakre4 years ago

The section in the PHP Manual is the Date and Time PHP extension, you find more info in the List of Supported Timezones. It infact is based on PECL timezonedb which is based on the "Olson" database. Please contact your servers administrator for a fix.

Note: See TracTickets for help on using tickets.