Make WordPress Core

Opened 16 years ago

Closed 10 years ago

#10856 closed enhancement (maybelater)

Move unessential comment fields to the comment meta table

Reported by: scribu's profile scribu Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.9
Component: Comments Keywords: has-patch dev-feedback
Focuses: Cc:

Description

The wp_comments table has 3 less-used fields that would be better placed in the new commentmeta table. These are:

  • comment_author_IP
  • comment_agent
  • comment_karma

Attachments (1)

comment_fields.diff (2.9 KB) - added by scribu 16 years ago.
Saves new data to comment meta. Still needs code for migrating old data

Download all attachments as: .zip

Change History (11)

#1 @scribu
16 years ago

Related: #10747

@scribu
16 years ago

Saves new data to comment meta. Still needs code for migrating old data

#2 @dd32
16 years ago

  • Keywords dev-feedback added
  • Version set to 2.9

Any chance of this in 2.9? With windows 7, The user agents are starting to grow.. making the field longer in the comments table works around it.. but storing meta as meta would be better way forward.

this patch could do with a compat to merge commentmeta with the $comments object if thats not already done.

#3 @scribu
16 years ago

  • Cc scribu@… added

#4 follow-up: @Denis-de-Bernardy
16 years ago

Imo, the IP address should stay in the comments table. It's potentially useful in there in order to mass-delete spammy comments.

#5 @ryan
16 years ago

  • Milestone changed from 2.9 to Future Release

#6 @nacin
15 years ago

Cross referencing #12668. Should be handled together.

#7 @gruvii
14 years ago

  • Cc gruvii added

#8 in reply to: ↑ 4 @mitchoyoshitaka
14 years ago

  • Cc mitcho@… added

Replying to Denis-de-Bernardy:

Imo, the IP address should stay in the comments table. It's potentially useful in there in order to mass-delete spammy comments.

Well, getting that data should just be one join away. It's not worth keeping that column in this table just for that reason. We should optimize for the 90% use case.

#9 @chriscct7
11 years ago

  • Summary changed from Move unesential comment fields to the comment meta table to Move unessential comment fields to the comment meta table

@nacin why is #12668 related to this one?

#10 @wonderboymusic
10 years ago

  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed

no movement in Years

Note: See TracTickets for help on using tickets.