WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #10861, comment 14


Ignore:
Timestamp:
03/05/11 19:42:15 (3 years ago)
Author:
hakre
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10861, comment 14

    initial v1  
    33The "variable" code looks pretty much copied over from some other project without propper checking wether it is useable here or not. It might be that the other project needs such a flexibility but it's perfectly unfitting in these cases here in WP. 
    44 
    5 There is just no need to put hacks in where no hack is needed. Each extending class knows exactly it's parent and can call without any problems the PHP4 constructor. We do not need any PHP5 __construct functions at all, PHP5 handles the PHP4 constructors just properly. 
     5There is just no need to put hacks in where no hack is needed. Each extending class knows exactly it's parent and can call without any problems the PHP4 constructor. We do not need any PHP5 `__construct` functions at all, PHP5 handles the PHP4 constructors just properly. 
    66 
    77This will also help to migrate the code more properly to PHP5 some day. There is no need of a mix of PHP4 and PHP5 constructors. That's just overhead. In those cases where this can be corrected without changing much code I've made that. I have not checked the {{{*_Walker}}} classes until now.