Make WordPress Core

Opened 15 years ago

Closed 9 years ago

#10863 closed enhancement (wontfix)

Gravatars without email all end up looking generic

Reported by: thecodepro's profile thecodepro Owned by:
Milestone: Priority: low
Severity: minor Version:
Component: Comments Keywords: has-patch dev-feedback
Focuses: Cc:

Description

When your blog has this option turned on

"Comment author must fill out name and e-mail"

and multiple users leave comments, if these users do not provide email addresses it will appear that they are all the same user as the identicon/monsterid/etc icons will be the same.

With two additional lines of code, you can substitute the IP address in place of the email to get a unique hash in order to distinguish one anonymous/non-emailed user from another.

Patch is attached

Attachments (2)

avatar.diff (509 bytes) - added by thecodepro 15 years ago.
adds code to use IP address if email is empty for gravatar handoff
avatar-nonce.diff (658 bytes) - added by thecodepro 15 years ago.
Same as before, but using the NONCE key to obsucre the IP from rainbow reading

Download all attachments as: .zip

Change History (9)

@thecodepro
15 years ago

adds code to use IP address if email is empty for gravatar handoff

#1 @scribu
15 years ago

  • Milestone changed from Unassigned to 2.9

#2 @hakre
15 years ago

Isn't it possible to reverse-engeneer the comment's authors IP-address then? Some hashing needed?

#3 @thecodepro
15 years ago

Yes, I suppose you could use a rainbow table to reverse the IP address for anonymous posters.

Could probably salt this with on of those constants defined in wp-config.php if you wanted to make it UBER secure.

I'll look into that real quick...

@thecodepro
15 years ago

Same as before, but using the NONCE key to obsucre the IP from rainbow reading

#4 @ryan
15 years ago

  • Milestone changed from 2.9 to Future Release

#5 @computerwiz908
13 years ago

  • Keywords comments gravatar avatar removed

#6 @chriscct7
10 years ago

  • Keywords dev-feedback added

This would probably be better suited as a plugin which can simply filter the get_gravatar function and if the user's email address doesn't return a gravatar then implement the above idea.

#7 @rachelbaker
9 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I don't think the use case is broad enough to warrant a core change the default avatar display. Without any real activity in 6 years, I am closing this as a wontfix.

Note: See TracTickets for help on using tickets.