WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#10871 closed defect (bug) (worksforme)

Folded Admin Menu Highlight

Reported by: Jick Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.9
Component: UI Keywords: has-patch gsoc ui-feedback
Focuses: Cc:
PR Number:

Description

One thing that has been bugging me for a while is the fact that the folded version of the WordPress admin menu doesn't have the white highlight line that the unfolded menu has. Is there a reason for this or is it just a fluke?

Attachments (6)

admin-menu.gif (13.5 KB) - added by Jick 10 years ago.
10871.diff (121.1 KB) - added by wojtek.szkutnik 9 years ago.
2010-07-15_00-31.jpg (2.3 KB) - added by wojtek.szkutnik 9 years ago.
admin-menu.png (53.5 KB) - added by TECannon 9 years ago.
Screenshots of problem & fixes
10871-fresh-menu-fix1.diff (729 bytes) - added by TECannon 9 years ago.
Fix #1 - For Fresh Menu
10871-fresh-menu-fix2.diff (1.3 KB) - added by TECannon 9 years ago.
Fix Version 2 - for fresh menu

Download all attachments as: .zip

Change History (19)

@Jick
10 years ago

#1 follow-up: @azaozz
10 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Will have to wait a little longer for this. As soon as the browsers start to support CSS 3.0 borders we can change these to look a lot better.

#2 in reply to: ↑ 1 @Jick
10 years ago

  • Milestone Unassigned deleted

Replying to azaozz:

Will have to wait a little longer for this. As soon as the browsers start to support CSS 3.0 borders we can change these to look a lot better.

Well, I achieved the image I attached with an image already in WordPress. I just put this on all LI's in the menu:

background: #f1f1f1 url(../images/menu-bits.gif) repeat-x scroll left -379px;

I put it on all LI's because I couldn't figure out where exactly it should go in the CSS to apply it to just the folded menu. There's no reason to apply it to all LI's because the unfolded menu already has that background. I'm just not real sure how all the CSS currently works.

So, it's possible now, I'm just not 100% sure how to do it...

It would be real easy for someone who knows all the details about the CSS.

#3 @Jick
10 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

#4 @hakre
10 years ago

looks to me like the original designer has forgotten this.

the css-3 argument is pretty much misleading imho.

#5 @Jick
10 years ago

  • Cc Jick added

#6 @Jick
10 years ago

  • Keywords needs-patch added
  • Milestone set to 2.9

#7 @ryan
10 years ago

  • Milestone changed from 2.9 to Future Release

#8 @wojtek.szkutnik
9 years ago

  • Cc wojtek.szkutnik@… added
  • Keywords has-patch gsoc added; needs-patch removed

looks much better now

#9 @nacin
9 years ago

  • Keywords ui-feedback added

Thanks! Marking for UI feedback. This kind of patch would generally go through the UI working group.

Also, no need to compress CSS and JS, it only increases the patch file size, causes the patch to become stale the moment an unrelated line in the file is changed, and makes the patch more bulky to review. We compress on commit.

#10 @JohnONolan
9 years ago

@wojtek Please upload screenshots of UI patches so that they're easier for us UI folk to review - many thanks!

@TECannon
9 years ago

Screenshots of problem & fixes

@TECannon
9 years ago

Fix #1 - For Fresh Menu

@TECannon
9 years ago

Fix Version 2 - for fresh menu

#11 @TECannon
9 years ago

I zoomed in on the screen shots so it's easy to see the differences between versions.

#12 @chexee
8 years ago

  • Resolution set to worksforme
  • Status changed from reopened to closed

Not relevant since the refresh in 3.2

#13 @SergeyBiryukov
8 years ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.