Context Navigation

← Previous Ticket
Next Ticket →

#10879 closed defect (bug) (fixed)

nonlocalised strings in edit functions

Reported by:	thomask	Owned by:	nbachiyski
Priority:	normal	Milestone:	2.9
Component:	I18N	Version:
Severity:	trivial	Keywords:
Cc:		Focuses:

Description

link-template.php
216 function edit_post_link($link = 'Edit This', $before = , $after = ) {

should be probably 'Edit This', so it could be translated

the same in edit_comment_link (line 236)

Attachments (1)

10879.diff (1.5 KB ) - added by ryan 17 years ago.

Download all attachments as: .zip

Change History (7)

#1 @thomask
17 years ago

oh, wiki have formated it, i meant two underscores in front of 'Edit This' (and parenthesis). So _ _ ( 'Edit This' )

#2 @ryan
17 years ago

Values for argument defaults must be constant. Function output is not allowed. What we've been doing is converting the default to null and then setting null arguments to the translated default in the function body.

@ryan
17 years ago

Attachment 10879.diff added

#3 @ryan
17 years ago

Try that.

#4 @ryan
17 years ago

Resolution → fixed
Status new → closed

(In [11987]) Localize default strings for edit_comment_link() and edit_post_link(). fixes #10879

#5 @nbachiyski
17 years ago

Ryan, why didn't you use is_null()?

#6 @Denis-de-Bernardy
17 years ago

Milestone Unassigned → 2.9

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#10879 closed defect (bug) (fixed)

nonlocalised strings in edit functions

Description

Attachments (1)

Change History (7)

#1 @thomask 17 years ago

#2 @ryan 17 years ago

@ryan 17 years ago

#3 @ryan 17 years ago

#4 @ryan 17 years ago

#5 @nbachiyski 17 years ago

#6 @Denis-de-Bernardy 17 years ago