Opened 14 years ago
Closed 14 years ago
#10893 closed defect (bug) (fixed)
get_site_option should activate the same filters as the mu version
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.9 | Priority: | lowest |
Severity: | normal | Version: | 2.8.4 |
Component: | General | Keywords: | reporter-feedback needs-testing |
Focuses: | Cc: |
Description
No much point in having the same function names if they behave differently.
Namely, call the pre_site_option_${key} filter before getting the option and site_option_${key} to filter the return value.
Attachments (1)
Change History (6)
#1
@
14 years ago
- Keywords reporter-feedback added
- Milestone changed from Unassigned to 2.9
- Owner set to westi
- Status changed from new to accepted
How is that?
Does this give you the same behaviour.
#4
follow-up:
↓ 5
@
14 years ago
- Keywords needs-testing added
- Resolution fixed deleted
- Status changed from closed to reopened
some feedback on the (as untested marked but comitted) patch:
$key is not validated in any of these functions.
a filter returning false as the value FAILS to work.
#5
in reply to:
↑ 4
@
14 years ago
- Resolution set to fixed
- Status changed from reopened to closed
Replying to hakre:
some feedback on the (as untested marked but comitted) patch:
$key is not validated in any of these functions.
The same as the mu function and the same as get_option itself.
a filter returning false as the value FAILS to work.
The same as the mu function and the same as get_option itself.
The idea behind this change was for that same behaviour to be preserved.
Closing as FIXED.
If you wish you could open a new ticket for a future release to all for shortcircuit to return false and be used.
Patch for the filters