WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10906 closed defect (bug) (duplicate)

incorrect logic in upgrader class

Reported by: Denis-de-Bernardy Owned by:
Milestone: Priority: normal
Severity: major Version: 2.8.4
Component: Upgrade/Install Keywords: needs-patch
Focuses: Cc:

Description

on sites where FTP maps the WP ABSPATH to /, the core ugprader fails.

fs_connect() ends up testing !find_folder() at one point, instead of bailing on abspath.

Patch attached.

Attachments (2)

10906.diff (672 bytes) - added by Denis-de-Bernardy 5 years ago.
10906.2.diff (785 bytes) - added by Denis-de-Bernardy 5 years ago.
patch also fixes a typo in the code

Download all attachments as: .zip

Change History (6)

@Denis-de-Bernardy5 years ago

@Denis-de-Bernardy5 years ago

patch also fixes a typo in the code

comment:1 @Denis-de-Bernardy5 years ago

  • Severity changed from normal to major
  • Version set to 2.8.4

comment:2 @Denis-de-Bernardy5 years ago

  • Keywords needs-patch added; has-patch tested removed

mm, there should actually be a better patch, which is to cache ABSPATH over in find_folder(). it'll give a performance bonus on top.

comment:3 @dd325 years ago

  • Milestone 2.9 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

See #10541 and [11862]

comment:4 @dd325 years ago

which is to cache ABSPATH over in find_folder(). it'll give a performance bonus on top.

That also happens at present, However, the cached values are only used for direct lookups, Not used for speeding up locating the child folders. Suggest opening a new ticket if you'd like to implement it.

Note: See TracTickets for help on using tickets.