Complete the rewrite API

[scribu]

Every public method of the WP_Rewrite class should have a standalone function that calls it.

Currently, add_permastruct() and flush_rewrite_rules() are missing.

[scribu]

Current patch adds the 2 missing functions. Still need to replace all direct $wp_rewrite->* calls.

[hakre]

@param $hard bool is not explained. what does true or false mean in terms of the function creation.

[ryan]

I tweaked the summary cause when I see "complete rewrite" I tend to tune out. :-)

[scribu]

Replying to hakre:

@param $hard bool is not explained. what does true or false mean in terms of the function creation.

Added explanation.

[hakre]

Something that popped in my mind somewhere in the last day(s):

These functions fail if the global $wp_rewrite is either not set or contains the wrong object then the function expects. Checks should be added in those and in all the other global functions that are part of the rewrite API.

This is common in other public function in trunk as far as I remember.

[nacin]

Seems logical enough to me to add these.

[nacin]

(In [13438]) Introduce add_permastruct() and flush_rewrite_rules(), wrappers for the corresponding WP_Rewrite methods. Fixes #10912 props scribu