WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#10960 closed defect (bug) (fixed)

?author=-N forwards to wrong canonical URL

Reported by: markjaquith Owned by: markjaquith
Milestone: 2.9 Priority: high
Severity: major Version: 2.8.4
Component: Canonical Keywords:
Focuses: Cc:

Description

/feed/?author=-123 will redirect to the feed for that author.

Expected: No forwarding, stay on that URL and exclude that author.

I'm on it.

Change History (4)

#1 @markjaquith
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12034]) Do not do a canonical redirect for negated author query strings. fixes #10960

#2 @aaroncampbell
10 years ago

Wouldn't it be far more efficient to use ctype_digit( $_GET['author'] ) rather than a regular expression?

#3 @filosofo
10 years ago

Actually a better optimization would probably be leaving the regular expression and taking out the ! empty() check (ctype_digit() returns true for empty strings in some PHP versions).

#4 @markjaquith
10 years ago

(In [12040]) Remove redundant !empty() checks. props filosofo. see #10960

Note: See TracTickets for help on using tickets.