WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#10973 closed task (blessed) (fixed)

Grand Unified Upgrader

Reported by: ryan Owned by:
Milestone: 2.9 Priority: high
Severity: normal Version: 2.9
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

Turn Tools->Upgrade into an auto upgrade hub. Allow upgrading core, themes, and plugins all from one screen.

Attachments (3)

10973.diff (3.7 KB) - added by ryan 6 years ago.
Starting to rough in UI, abstract a couple things.
10973.showactive.diff (766 bytes) - added by sivel 6 years ago.
Differentiate between active and inactive plugins
10973.missing-hook.diff (323 bytes) - added by Denis-de-Bernardy 6 years ago.

Download all attachments as: .zip

Change History (25)

comment:1 @ryan6 years ago

See #8589 for bulk upgrade discussion that applies here.

@ryan6 years ago

Starting to rough in UI, abstract a couple things.

comment:2 @ryan6 years ago

(In [12066]) Start roughing in GUU. see #10973

comment:3 @ryan6 years ago

(In [12086]) GUU UI rough in. see #10973

comment:4 @ryan6 years ago

(In [12087]) GUU UI rough in. see #10973

comment:5 @ryan6 years ago

(In [12093]) GUU UI rough in. see #10973

comment:6 @ryan6 years ago

(In [12097]) Plugin bulk upgrade rough in. see #10973

comment:7 @azaozz6 years ago

(In [12107]) Add subtitles and opening/closing DIVs on GUU results screen, see #10973

@sivel6 years ago

Differentiate between active and inactive plugins

comment:8 @husobj6 years ago

Just saw this in bleeding edge dev.

Will this be including links to "View version X.x.x Details" for the plugins like the plugin page?

Think it is still useful to have quick access to view a plugin's change log before doing a bulk upgrade?

comment:9 @sivel6 years ago

  • Cc matt@… added

comment:10 @dd326 years ago

for some background thoughts on the plugin bulk upgrade see this ticket: #8589

I'd like to bring up a slight issue with the bulk plugin upgrade however, It works well, plugins get upgraded OK. But theres a problem with re-activation.

All the re-activation iframes load at once, Before plugins are upgraded, they're deactivated, All the iframes load with get_option('active_plugins') == active_plugins - upgrade_plugins.

Once the iframes finish loading, they update 'active_plugins' to include the plugin being tested.

The issue is, That, The data the pages are saving, are potentially stale as another thread may have modified it.. I couldnt understand why a few plugins were deactivated on my blog.. But this thought just hit me, and it would certainly make sense..

I've not verified this, But i'm pretty certain it's occurring.

comment:11 @ryan6 years ago

Maybe we should put the site into maintenance mode for the duration of the bulk upgrade and forget deactivating and activating.

comment:12 @ryan6 years ago

(In [12157]) Put site into maintenance mode during bulk plugin upgrade. Skip plugin deactivate/activate. Add compatibility info. see #10973

comment:13 @demetris6 years ago

  • Cc dkikizas@… added

I think we need to somehow link to upgrade-core.php from plugins.php?plugin_status=upgrade. Or, to put it more generally, to make people aware that there is tool from mass-upgrading.

(Meanwhile, the admin UI is getting busier and busier, and eventually we’ll have to do something about that too. :-) )

comment:14 @Viper007Bond6 years ago

#11130 When upgrading a single plugin, it's deactivated, upgraded, and then never reactivated. I assume the issue is related to this ticket/[12157].

comment:15 @Denis-de-Bernardy6 years ago

I've attached a patch in order to allow plugins to insert the needed functionality for mass theme updates, and mass-updates of whatever else may be applicable.

comment:16 @ryan6 years ago

(In [12204]) Add core_upgrade_preamble action. Props Denis-de-Bernardy. see #10973

comment:17 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

comment:18 @ryan6 years ago

(In [12374]) Show Upgrade Notice for plugins. see #10973

comment:19 @TobiasBg6 years ago

Question (I know it doesn't belong here, put wp-hackers doesn't take my emails somehow at the moment):
For [12374]: As a plugin author, how and where can I set that upgrade notice? Couldn't find anything...

comment:20 @arnee6 years ago

  • Cc himself@… added

comment:21 @ryan6 years ago

(In [12436]) Give feedback when Upgrade Plugins is clicked but no plugins are selected. see #10973

comment:22 @ryan6 years ago

(In [12437]) Give feedback when Upgrade Plugins is clicked but no plugins are selected. see #10973 for 2.9

Note: See TracTickets for help on using tickets.