wpautop filter may product invalid markup

[idanso]

The wpautop filter, enabled by default on Wordpress 1.5, produces not well formed XHTML in some cases.

One such case occurs when the input has a 'pee' block contained within a 'div' block, and there is a newline, followed by atext between the end of the 'pee' block and the end of the 'div' block.

In such a case, wpautop will open a 'pee' block at the start of the text block, but will not close it.

For example:
<div>
<p>Hello</p>
World</div>

Will product:
<div>
<p>Hello</p>
<p>World</div>

[bronski]

This could be related to ​http://mosquito.wordpress.org/view.php?id=488

It was once fixed with pre and code but is broken with code now.

[Jon Leighton (Turnip)]

Well, here's a patch (kinda). It might need some more elements, and probably needs a bit more testing, but it worked for me...

	$pee = preg_replace('/\n?(.+?)(?:\n\s*\n|\z)/s', "\t<p>$1</p>\n", $pee); // make paragraphs, including one at the end 
+	$pee = preg_replace('!(<(?:div|address|form)[^>]*>)([^<]+)</p>!', "$1<p>$2</p>", $pee);
+	$pee = preg_replace('!<p>([^<]+)\s*?(</(?:div|address|form)[^>]*>)!', "<p>$1</p>$2", $pee);
	$pee = preg_replace('|<p>\s*?</p>|', '', $pee); // under certain strange conditions it could create a P of entirely whitespace 

To prevent the invalid markup being produced, I found that at least two newlines were needed between the containing elements's tag (div, address etc.) and the text that needs to be peed. So this would be ok:

<div>

some words

some more words

</div>

But this wouldn't:

<div>
some words

some more words
</div>

[filosofo]

Jon Leighton's patch (which I've attached) works for me.

[matt]

The patch breaks when there is any markup in the string:

<div>
some words

some more <a href="">and a link</a> words
</div>

[rob1n]

Dupe of #3669, which has since been fixed.