WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#10999 closed defect (bug) (fixed)

Broken Themes feature is broken

Reported by: hakre Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.8.4
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

Nice title . This is what happens: If a Stylesheet is missing in a theme directory the Name is not displayed (hence there is no name) leaving only a message that something is broken or not.

Suggestion for a fix: Display the name of the directory instead in the "Name" column. Description can contain the full directory.

Attachments (3)

WordPress_1256193285241.png (71.3 KB) - added by hakre 6 years ago.
Screenshot
10999.diff (1.6 KB) - added by sivel 6 years ago.
$theme_dir was being overwritten in a sub while loop. Rename $theme_subdir to $theme_subdirs and use $theme_subdir for the sub while loop.
10999.2.diff (2.5 KB) - added by sivel 6 years ago.
Added styling to make it not quite so ugly.

Download all attachments as: .zip

Change History (8)

@hakre6 years ago

Screenshot

comment:1 @hakre6 years ago

Hey, nice Ticket ID as well.

comment:2 @sivel6 years ago

  • Component changed from General to Themes
  • Owner set to sivel
  • Status changed from new to assigned

@sivel6 years ago

$theme_dir was being overwritten in a sub while loop. Rename $theme_subdir to $theme_subdirs and use $theme_subdir for the sub while loop.

comment:3 @sivel6 years ago

  • Cc matt@… added
  • Keywords has-patch added

With this patch it makes it apparent that there are some styling issues. I don't claim to be a front end developer, so I may not be able to make that happen.

On a side not I also added '.svn' to the list of directories to ignore.

hakre or anyone else if you could test this patch and add the "tested" keyword I'd appreciate it.

@sivel6 years ago

Added styling to make it not quite so ugly.

comment:4 @sivel6 years ago

  • Owner sivel deleted

The recent patch adds some styling. You will need to define STYLE_DEBUG to test. We will need to also make the necessary modifications in rtl.dev.css too I imagine as well as crete the minified versions.

comment:5 @westi6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12091]) Display better information about broken themes when there is no stylesheet. Fixes #10999 props sivel.

Note: See TracTickets for help on using tickets.