WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#11002 closed defect (bug) (fixed)

file.php docs + fixes + filter

Reported by: dd32 Owned by: dd32
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.9
Component: Filesystem API Keywords: has-patch
Focuses: Cc:

Description

Just a patch to merge some changes i've got locally:

  • Documentation updated for wp-admin/includes/file.php (Including @since)
  • Bugfix: If a non-numeric port is provided, ignore it. (This is to cover the bases of some people who manage to end up with junk in the port setting which ends up stored in the database)
  • Bugfix: Do not offer FTP SSL when the underlying transport does not support it (only the FTP Extension does, The Sockets implementation can only handle plain-old-ftp)
  • Enhancement: The connection types on the FTP credential page is an array and filtered, Ie. FTP|FTP SSL|SSH, Allows plugins and custom code to modify this list.. side effect of simplifying the code for the previous item

Attachments (1)

11002.diff (10.9 KB) - added by dd32 5 years ago.

Download all attachments as: .zip

Change History (6)

dd325 years ago

comment:1 dd325 years ago

  • Enhancement: Return (bool)true on success of copy_dir(), At present, Return values are false for failure, and null on success.

comment:2 dd324 years ago

  • Keywords commit dev-feedback added

No String changes, Only a extra filter, Much more phpdoc coverage.. Any chance for a commit?

comment:3 azaozz4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [12151]

comment:4 dd324 years ago

  • Keywords commit dev-feedback removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Theres a copy-paste error in that patch, Serves me right for backporting into trunk and not properly testing under FTP.

s/esc_atr/esc_attr/ props "Harald Nesland" <hn@…> on wp-hackers

comment:5 azaozz4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [12152]) Fix typo, props Harald Nesland, fixes #11002

Note: See TracTickets for help on using tickets.