file.php docs + fixes + filter

[dd32]

Just a patch to merge some changes i've got locally:

• Documentation updated for wp-admin/includes/file.php (Including @since)
• Bugfix: If a non-numeric port is provided, ignore it. (This is to cover the bases of some people who manage to end up with junk in the port setting which ends up stored in the database)
• Bugfix: Do not offer FTP SSL when the underlying transport does not support it (only the FTP Extension does, The Sockets implementation can only handle plain-old-ftp)
• Enhancement: The connection types on the FTP credential page is an array and filtered, Ie. FTP|FTP SSL|SSH, Allows plugins and custom code to modify this list.. side effect of simplifying the code for the previous item

[dd32]

• Enhancement: Return (bool)true on success of copy_dir(), At present, Return values are false for failure, and null on success.

[dd32]

No String changes, Only a extra filter, Much more phpdoc coverage.. Any chance for a commit?

[azaozz]

Fixed in [12151]

[dd32]

Theres a copy-paste error in that patch, Serves me right for backporting into trunk and not properly testing under FTP.

s/esc_atr/esc_attr/ props "Harald Nesland" <hn@…> on wp-hackers

[azaozz]

(In [12152]) Fix typo, props Harald Nesland, fixes #11002