Make WordPress Core

Opened 15 years ago

Closed 15 years ago

#11021 closed defect (bug) (fixed)

Multiple Size Options Selected by Default

Reported by: miqrogroove's profile miqrogroove Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.7
Component: Media Keywords: has-patch
Focuses: Cc:

Description

After upgrading from v2.7 to v2.8.4, when inserting images into posts the default size option is BOTH Medium and Full. Two radio options are selected.

Setting severity Normal as this bug doesn't cause any huge headaches for me yet.

Attachments (2)

wordpress-bug-11021-screen1.jpg (130.7 KB) - added by miqrogroove 15 years ago.
wp-bug-11021-admin-includes-media.php.patch (1.2 KB) - added by miqrogroove 15 years ago.

Download all attachments as: .zip

Change History (11)

#1 @scribu
15 years ago

  • Keywords reporter-feedback added
  • Priority changed from high to normal

Could you provide a screenshot?

#2 @miqrogroove
15 years ago

Yep, I hope that helps. I can only reproduce on that one screen where I upload images in a new or draft post. If I go to the Gallery or Media Library tabs it doesn't do that to me.

#3 @scribu
15 years ago

  • Keywords reporter-feedback removed

That's really weird. Maybe it's caused by a plugin?

#4 @miqrogroove
15 years ago

Not sure if it's relevant, but I have in the current theme:

$GLOBALS['content_width'] = 800;

#5 @miqrogroove
15 years ago

Rather than a plugin, I would suspect it's to do with this nonsense in wp-admin/includes/media.php

			if ( $checked && !$enabled )
				$checked = '';
			// if $checked was not specified, default to the first available size that's bigger than a thumbnail
			if ( !$checked && $enabled && 'thumbnail' != $size )
				$checked = $size;

The $checked value is being cleared when Full size is not available, thus WP is indeed instructing the browser to check multiple sizes.

#6 @miqrogroove
15 years ago

*Large (not full)

No worries, I'll work on a patch.

#7 @miqrogroove
15 years ago

  • Keywords has-patch added

Patched against trunk, tested on 2.8.4, works perfectly on my blog.

#8 @miqrogroove
15 years ago

  • Version changed from 2.8.4 to 2.7

Cross-Reference #9255

#9 @azaozz
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12188]) Fix improper selection of radio buttons, improve JS for storing image settings, fixes #11021

Note: See TracTickets for help on using tickets.