Cannot trash Media without title

[Simek]

Tested on various files.

This problem only exist if file has non-required title field (for ex. PDF, TXT). After upload and delete title new media is added to library with "(no title)" caption in media browser. Until we'll add a title in edit media page this media cannot be deleted in normal and bulk way. Page reload, notification appears, but nothing happened.

[caesarsgrunt]

Odd. The problem seems to be in wp_insert_post, but I'm not sure exactly what it is...

[caesarsgrunt]

The problem is with lines 1613-1618 of wp-includes/post.php, in wp_insert_post(). They throw an error if the content, title, and excerpt are all empty, which has he effect of making it impossible to update (eg trash) an attachment without a title. I don't know what the purpose of these lines is... but my patch fixes the problem by making it not throw the error if the post is an attachment.

[nacin]

Replying to caesarsgrunt:

The problem is with lines 1613-1618 of wp-includes/post.php, . . . I don't know what the purpose of these lines is...

I tracked down that code as originating in ​http://core.trac.wordpress.org/ticket/2390. The excerpt check was added some revisions later.

[caesarsgrunt]

Ah; thanks nacin.

Now, if someone would commit the patch...

[automattor]

(In [12273]) Don't require titles for attachments. Props caesarsgrunt. fixes #11052