More Flexibility in args['post_parent']

[miqrogroove]

I am struggling to reduce query count on some of my custom code, and frankly I can't see a way to do it in the existing code base.

One of the stumbling blocks is get_children() relying on the WP_Query::get_posts() restriction for is_numeric($qpost_parent?)

The cost is 3 queries for every call to get_children().

Either I am incredibly dense about how attachment queries are supposed to work, or there needs to be a way to query multiple parents in one call.

[miqrogroove]

p.s. I might play around with the posts_where_paged filter and see what that gets me.

[miqrogroove]

The filter I wrote still works so far. It's ugly but I don't have the time to hack WP_Query before beta starts.

[wonderboymusic]

Introduce post_parent__in, post_parent__not_in - patch attached.

Example usage:

php -r "require 'wp-load.php'; \
print_r( get_posts( array( 'post_parent__in' => array( 47 ), 'post_type' => 'page', 'orderby' => 'post_parent__in' ) ) );"

[nacin]

See #13927, attachment:13927.diff:ticket:13927​. This one looks a bit more complete, and is certainly updated for trunk, at least.

[nacin]

#13927 was marked as a duplicate.

[wonderboymusic]

yeah, I grep'd for post__in and went from there - your spirit lives on in the middle there

[nacin]

Looks good to me. Mark?

[nacin]

Agreed with Ryan, could use some tests.

[wonderboymusic]

attached some Unit Tests

[nacin]

post-parent-in-tests.diff​ look good at a glance, but these tests also pass without the post_parent__in patch applied.

[Japh]

This solves #9470.

[kovshenin]

Refreshed in 11056.diff​ and added tests in 11056.tests.diff​ run with --group 11056.

[nacin]

In 1217/tests:

Tests for post_parent__in and post_parent__not_in. props kovshenin. see #11056.

[nacin]

In 23436:

WP_Query: post_parent__in and post_parent__not_in. props wonderboymusic. fixes #11056.