Wrong term link when permalinks turned off

[scribu]

Site URL: ​http://localhost/wp

Permalinks: Default

Taxonomy: 'genre'

Expected result:

​http://localhost/wp/?genre=jazz

Actual result:

​http://localhost/wpgenre/jazz

[ryan]

See also #11179

[ryan]

I think adding the slash to the add_permastruct() call will break pretty permas. The fix for #11179 should fix the slashing. That leaves returning pretty links when the crufty links should be returned. I think we can fix that by having get_extra_permastruct() return false if pretty links are not on, as is done with other get_*_permastruct calls.

[ryan]

(In [12230]) Don't return extra permastructs if pretty permalinks not turned on. Props scribu. fixes #11061

[ryan]

Try that out. Re-open if I messed it up. :-)

[scribu]

Slight glitch:

Permalinks off: ​http://localhost/wp/?genre=jazz (ok)

Permalinks on: ​http://localhost/wp//genre/jazz/ (notice the double slash after /wp)

[scribu]

remove double slash

[scribu]

$wp_rewrite->get_extra_permastruct($taxonomy); adds a slash at the beginning now, which is good.

That's what caused the extra slash.

[ryan]

(In [12241]) Fix double slashing. Props scribu. fixes #11061