Allow 'include' & 'exclude' args to be arrays

[scribu]

Most of the time, the term ids you want to include are retrieved as an array, using $wpdb.

To avoid having to join(',', $term_ids), only to have them preg_split() afterwards, I think this would be really useful.

[ryan]

Looks like a cut-and-paste error. Second $include should be $exclude.

[scribu]

Fix copy-paste error

[westi]

Looks like we should also do this for $exclude_tree and we should probably set the default values at the top of the function to array() instead of '' so we can avoid the preg_split.

Wondering if we should refactor some of this code into a helper function as we have a lot of copy/paste going on here.

[scribu]

​get_terms.3.diff creates a helper function called _parse_get_terms_arg() and applies it to exclude, exclude_tree and include.

[scribu]

Use helper function

[scribu]

Rename helper function to wp_parse_id_list()

[scribu]

get_terms.4.diff moves the helper function wp_parse_id_list() to wp-includes/functions.php so that it can be used in other contexts.

[westi]

(In [12658]) Add support to get_terms() to allow 'include' & 'exclude' args to be arrays(). Fixes #11076 props scribu.

[sirzooro]

I think it will be better to change generated SQL from:

AND (t.term_id = 1 OR t.term_id = 2 OR ...)
AND (t.term_id <> 1 AND t.term_id <> 2 AND ...)

to:

AND t.term_id IN (1, 2, ...)
AND t.term_id NOT IN (1, 2, ...)

[scribu]

+1 on that. Please open a new ticket.

[scribu]

Should also do this for get_pages() and get_posts()

[scribu]

Use wp_parse_id_list() in get_posts() and get_pages()

[scribu]

post.php.diff:

• use wp_parse_id_list() in get_posts() and get_pages()

• replace if ( count(...) ) with if ( !empty(...) )

[nacin]

(In [14133]) Allow include/exclude args to be arrays in get_posts() and get_pages(). Utilizes wp_parse_id_list(). props scribu, fixes #11076.

[miqrogroove]

I'm trying to figure out if something blew up here. In version 2.9 this was working fine:

        $ids = implode(',', $ids);
        $taxonomy = 'post_tag';
        $args = array('include' => $ids);
        $terms = get_terms($taxonomy, $args);

In version 3.0, get_terms is returning an empty array :( I'm working on a plugin upgrade that needs to be backward compatible, so I'm hoping this change doesn't mean CSVs are invalid now.

[miqrogroove]

Nevermind, it works fine. The tags I was testing were attached to drafts so they were coming up empty. Inputs handled as expected:

var_dump(wp_parse_id_list('16'));
array(1) {
  [0]=>
  int(16)
}