WordPress.org
Get WordPress

Make WordPress Core

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#11086 closed defect (bug) (fixed)

Don't query against entire users table in wp_dropdown_users()

Reported by: ryan Owned by: ryan
Priority: normal Milestone: 3.0
Component: Users Version: 2.9
Severity: normal Keywords: has-patch early
Cc: Focuses: multisite

Description

To be MU friendly, wp_dropdown_users() should use get_users_of_blog() or a like query.

Attachments (3)

11086-wp_dropdown_users.diff​ (1.7 KB ) - added by nacin 17 years ago.
11086-wp_dropdown_users.2.diff​ (809 bytes ) - added by nacin 17 years ago.
11086-wp_dropdown_users.3.diff​ (810 bytes ) - added by nacin 17 years ago.
Missing semi-colon.

Download all attachments as: .zip

Change History (10)

#1 @nacin
17 years ago

  • Keywords has-patch added
  • Version 2.8.5 → 2.9

@nacin
17 years ago

@nacin
17 years ago

#2 @nacin
17 years ago

Pretty sure we'd need $wpdb->get_blog_prefix in non-MU WP to be able to add $blog_id as an argument. First patch was incomplete in that regard, I thought I had pulled the $blog_id code before patching.

@nacin
17 years ago

Missing semi-colon.

#3 @ryan
17 years ago

  • Keywords early added
  • Milestone 2.9 → 3.0

Thanks for the patch. It looks good, but let's postpone this to 3.0.

#4 @nacin
17 years ago

  • Keywords multisite added

#5 @nacin
17 years ago

Patch still applies clean (thought offset) on r12962.

#6 @nacin
17 years ago

  • Resolution → fixed
  • Status new → closed

(In [13122]) Don't query against entire users table in wp_dropdown_users() to be multisite friendly. Fixes #11086

#7 @nacin
17 years ago

(In [13123]) s/$blog/$blog_id/ as an argument in wp_dropdown_users(), for consistency, see #11086

Note: See TracTickets for help on using tickets.