WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 6 years ago

#11114 closed defect (bug) (duplicate)

Bulk edit comments: Request-URI Too Large

Reported by: hakre Owned by: scribu
Milestone: Priority: normal
Severity: normal Version: 2.8.4
Component: Comments Keywords: needs-patch
Focuses: Cc:

Description

edit-comments.php allows to set the number of comments to edit at once. Setting those to a value to 500 to keep up with high-traffic sites, a full selected submit will result in a "Request-URI Too Large" message (on certain servers) which is a sign that wordpress violates the RFC of the URI especially the maximum length by RFC definition.

The solution is to submit the form via POST not GET.

Attachments (2)

edit-comments.php.diff (383 bytes) - added by scribu 9 years ago.
edit-comments.php.2.diff (1.1 KB) - added by scribu 9 years ago.
Search should still use GET method

Download all attachments as: .zip

Change History (19)

#1 @scribu
9 years ago

I'm pretty sure this was brought up before, but can't seem to find the ticket.

Yes, POST should be used for all bulk editing, not just for comments.

#2 @hakre
9 years ago

Yeah, looks like that procol limitation have not been taken into account while the last over-work of the backend was done. This is one realting to bulk editing posts: #10762

The tickets should be kept seperate because it looks like that a correct implementation might be contextually faster possible in certain domains of the backend then in other. That is because there is a lot of code for each section/domain (comments, posts etc.). Same bug only in terms of the concrete design flaw, not the same bug if you take the concrete code into consideration. Code duplication relates to bug duplication.

#3 @scribu
9 years ago

  • Keywords has-patch commit added

The fix is trivial, since WP uses $_REQUEST everywhere: just replace method="get" with method="post".

@scribu
9 years ago

Search should still use GET method

#4 @janeforshort
9 years ago

Will the current filter settings be preserved when searching?

#5 @scribu
9 years ago

  • Keywords needs-patch added; has-patch commit removed
  • Milestone changed from 2.9 to 3.0
  • Summary changed from Request-URI Too Large to Bulk edit comments: Request-URI Too Large

Sadly, no.

#6 @dd32
8 years ago

  • Milestone changed from 3.0 to Future Release

On the comments page, it makes sense to keep the filters for a search.

Since theres no patch here, I'm moving it to Future Release pending a patch.

I'm also inclined to merge #10762 into this ticket, Whilst they may be different functionalities, they're underpinned by the same defect, that is, selecing a bulk set can trigger the bug.

#7 @hakre
8 years ago

This seems to be an overall design issue in back-end. Same is for bulk editing media files. All points where bulk editing is an options should be checked and properly processed for proper HTTP compatibility. Related: #13443.

#8 @hakre
8 years ago

Related: #9259

#9 @jane
8 years ago

Same error when screen options set to 200, 100 and 50.

#10 @jane
8 years ago

  • Component changed from General to Comments

#11 follow-up: @scribu
8 years ago

  • Keywords gsoc added
  • Owner set to scribu
  • Status changed from new to assigned

I think I'll take this one, as part of my GSoC project.

#12 in reply to: ↑ 11 @azaozz
8 years ago

Replying to scribu: The solution should be relatively simple:

  • POST should be used to submit the request
  • all display filters (All, Pending, Approved, etc.) could be inserted as hidden fields to preserve them
  • the same solution should be applied to all screens that list items: posts, comments, attachments, etc.

#14 @voyagerfan5761
8 years ago

  • Cc WordPress@… added

#15 @scribu
8 years ago

  • Milestone changed from Future Release to 3.1
  • Resolution set to fixed
  • Status changed from assigned to closed

#16 @nacin
7 years ago

  • Keywords gsoc removed
  • Milestone changed from 3.1 to Future Release
  • Resolution fixed deleted
  • Status changed from closed to reopened

#16335. We'll need to fix this in conjunction with ajax redux.

#17 @scribu
6 years ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from reopened to closed

Closing as dup of #10762.

Note: See TracTickets for help on using tickets.