WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#11139 closed defect (bug) (fixed)

minor trackback_rdf() fix

Reported by: ramiy Owned by: ramiy
Milestone: 3.0 Priority: low
Severity: trivial Version: 2.8.5
Component: Comments Keywords: needs-depreceating needs-patch
Focuses: Cc:

Description (last modified by westi)

To remove in 3.0

Attachments (1)

11139.patch (1.2 KB) - added by ramiy 5 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 scribu5 years ago

  • Milestone changed from 2.8.6 to 2.9

comment:2 ramiy5 years ago

  • Keywords has-patch added
  • Owner set to ramiy
  • Status changed from new to accepted

ramiy5 years ago

comment:3 westi5 years ago

  • Keywords needs-depreceating added; has-patch removed
  • Milestone changed from 2.9 to Future Release
  • Type changed from task (blessed) to defect (bug)

I don't think we need this function at all anymore.

I guess it would be better just to depreceate it and return empty content as the discovery is automatic now.

comment:4 ramiy5 years ago

what do you mean when you say "the discovery is automatic now" ?

comment:5 westi5 years ago

We removed the calls to this in the default/classic themes back in 1.5.x in [2417].

I think we can just deprecate the functions - and they can return nothing as we use the rel="trackback" method for discovery.

comment:6 westi5 years ago

  • Description modified (diff)
  • Milestone changed from Future Release to 3.0

comment:7 rmccue4 years ago

  • Keywords needs-patch added

comment:8 nacin4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [13991]) Deprecate trackback_rdf(). fixes #11139

comment:9 follow-up: markjaquith4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This should be reverted. It breaks Trackback auto-discovery. rel="trackback" isn't a standardized discovery mechanism. Movable Type doesn't use it. The only standard discovery mechanism is the RDF block that was excised. It's fine that our bundled themes don't have it, but we shouldn't be breaking it for third party themes that have chosen to implement it.

comment:10 nacin4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [15363]) Restore trackback_rdf(). reverts [13991]. fixes #11139 for trunk.

comment:11 nacin4 years ago

(In [15364]) Restore trackback_rdf(). reverts [13991]. fixes #11139 for 3.0.

comment:12 nacin4 years ago

After some discussion with Mark it became obvious that while we no longer use the function in bundled themes, it should remain for the use by other themes.

Fun reading: http://comox.textdrive.com/pipermail/wp-hackers/2005-July/001706.html and http://foolswisdom.com/movable-type-to-support-pingback/comment-page-1/#comment-108014.

comment:13 in reply to: ↑ 9 westi4 years ago

Replying to markjaquith:

This should be reverted. It breaks Trackback auto-discovery. rel="trackback" isn't a standardized discovery mechanism. Movable Type doesn't use it. The only standard discovery mechanism is the RDF block that was excised. It's fine that our bundled themes don't have it, but we shouldn't be breaking it for third party themes that have chosen to implement it.

My bad I thought the new way was the way everyone used - I'm sure I read around at the time but obviously I got it wrong :-(

Note: See TracTickets for help on using tickets.