Make WordPress Core

Opened 17 years ago

Closed 16 years ago

Last modified 16 years ago

#11139 closed defect (bug) (fixed)

minor trackback_rdf() fix

Reported by: ramiy Owned by: ramiy
Priority: low Milestone: 3.0
Component: Comments Version: 2.8.5
Severity: trivial Keywords: needs-depreceating needs-patch
Cc: Focuses:

Description (last modified by westi)

To remove in 3.0

Attachments (1)

11139.patch (1.2 KB ) - added by ramiy 17 years ago.

Download all attachments as: .zip

Change History (14)

#1 @scribu
17 years ago

  • Milestone 2.8.62.9

#2 @ramiy
17 years ago

  • Keywords has-patch added
  • Owner set to ramiy
  • Status newaccepted

@ramiy
17 years ago

#3 @westi
17 years ago

  • Keywords needs-depreceating added; has-patch removed
  • Milestone 2.9Future Release
  • Type task (blessed)defect (bug)

I don't think we need this function at all anymore.

I guess it would be better just to depreceate it and return empty content as the discovery is automatic now.

#4 @ramiy
17 years ago

what do you mean when you say "the discovery is automatic now" ?

#5 @westi
17 years ago

We removed the calls to this in the default/classic themes back in 1.5.x in [2417].

I think we can just deprecate the functions - and they can return nothing as we use the rel="trackback" method for discovery.

#6 @westi
17 years ago

  • Description modified (diff)
  • Milestone Future Release3.0

#7 @rmccue
16 years ago

  • Keywords needs-patch added

#8 @nacin
16 years ago

  • Resolutionfixed
  • Status acceptedclosed

(In [13991]) Deprecate trackback_rdf(). fixes #11139

#9 follow-up: @markjaquith
16 years ago

  • Resolution fixed
  • Status closedreopened

This should be reverted. It breaks Trackback auto-discovery. rel="trackback" isn't a standardized discovery mechanism. Movable Type doesn't use it. The only standard discovery mechanism is the RDF block that was excised. It's fine that our bundled themes don't have it, but we shouldn't be breaking it for third party themes that have chosen to implement it.

#10 @nacin
16 years ago

  • Resolutionfixed
  • Status reopenedclosed

(In [15363]) Restore trackback_rdf(). reverts [13991]. fixes #11139 for trunk.

#11 @nacin
16 years ago

(In [15364]) Restore trackback_rdf(). reverts [13991]. fixes #11139 for 3.0.

#12 @nacin
16 years ago

After some discussion with Mark it became obvious that while we no longer use the function in bundled themes, it should remain for the use by other themes.

Fun reading: http://comox.textdrive.com/pipermail/wp-hackers/2005-July/001706.html and http://foolswisdom.com/movable-type-to-support-pingback/comment-page-1/#comment-108014.

#13 in reply to: ↑ 9 @westi
16 years ago

Replying to markjaquith:

This should be reverted. It breaks Trackback auto-discovery. rel="trackback" isn't a standardized discovery mechanism. Movable Type doesn't use it. The only standard discovery mechanism is the RDF block that was excised. It's fine that our bundled themes don't have it, but we shouldn't be breaking it for third party themes that have chosen to implement it.

My bad I thought the new way was the way everyone used - I'm sure I read around at the time but obviously I got it wrong :-(

Note: See TracTickets for help on using tickets.