WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#11167 closed enhancement (fixed)

Pass $size and $attr to post_image_html filter

Reported by: waltervos Owned by: MarkJaquith
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.9
Component: Media Keywords: has-patch needs-testing the_post_image filter
Focuses: Cc:

Description

It seems strange to me that get_the_post_image accepts $post_id, $size and $attr but when the filter post_image_html is applied, these parameters are not passed to it. This way, when $html is empty (when an image wasn't found) a plugin author only has $post_id to work with it. If you wanted to make a plugin that will use a default image where no post_image was found, you couldn't. A patch is attached to this ticket to illustrate what I mean.

Attachments (2)

get_the_post_image-enhancement.txt (953 bytes) - added by waltervos 4 years ago.
get_the_post_image-enhancement.diff (445 bytes) - added by scribu 4 years ago.
diff format

Download all attachments as: .zip

Change History (4)

scribu4 years ago

diff format

comment:1 ryan4 years ago

  • Owner set to MarkJaquith
  • Status changed from new to assigned

comment:2 markjaquith4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12211]) Pass some additional variables to post_image_html filter. props waltervos, scribu. fixes #11167

Note: See TracTickets for help on using tickets.