Flip Horizontally/Vertically Button Title Switched

[Coen Naninck]

This is my first ever report for WordPress (been a user for two years), so hopefully I'm doing this right.

1) In WP go to: Library > File > Edit > Edit image.
2) The 4th and 5th icons allow the image to be flipped.
3) Hover the mouse over each icon and notice the description seems to be switched (i.e. the description for the 4th icon (Flip horizontally) should be on the 5th icon and vice versa).

Indeed. The html classes were also switched. Attached patch fixes both.

This is actually right according to most image editing apps but wrong in others. Flip horizontally could mean "flip around the horizontal edge of the image" or "flip it so the left side is on the right". Perhaps we should change the tool tip as the icons show the edge flipping.

I think "Flip Horizontaly" is equivalent to "flip it so the left side is on the right" and seems more intuitive, to me, at least.

Replying to scribu:

I think "Flip Horizontaly" is equivalent to "flip it so the left side is on the right" and seems more intuitive, to me, at least.

I agree. I'd love to see examples of image editing apps that have them the way they are in WordPress right now, in which the "horizontal" and "vertical" corresponds to the edge. (Photoshop and MS Paint are per the patch.)

I think the icons are still fine with the patch, as the action is still what most people would expect. But, if it is left as is, then the tooltips should at least change to "Flip across the (horizontal|vertical axis".

(In [12281]) Swap the Flip horizontally and Flip vertically buttons in the image editor so they are more understandable, props scribu, fixes #11171