Make WordPress Core

Opened 15 years ago

Closed 12 years ago

#11178 closed defect (bug) (wontfix)

Fix for poor sidebar CSS in Kubrick theme

Reported by: chrisjean's profile chrisjean Owned by: iandstewart's profile iandstewart
Milestone: Priority: normal
Severity: normal Version: 2.9
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Rather than using a float to push the sidebar alongside the content area, Kubrick floats the content area and then uses a left-margin of 545 pixels to shove the sidebar over. This causes float and clear CSS rules to produce very odd results in the sidebar.

The attached patch changes the #sidebar left-margin from 545px to 50px and adds "float: left".

A site running the patched version of Kubrick has been tested in IE 6-8 and the latest versions of Firefox, Opera, Chrome, and Safari. All the browsers rendered the sidebar in the same position as before the patch with the exception of also fixing the float/clear problem.

Attachments (1)

kubrick-style.diff (362 bytes) - added by chrisbliss18 15 years ago.

Download all attachments as: .zip

Change History (10)

#1 @scribu
15 years ago

  • Milestone changed from Unassigned to 2.9

#2 @markjaquith
15 years ago

  • Milestone changed from 2.9 to 3.0

I'm wary that this may have unexpected results. Punting to 3.0 where a new theme should make me more willing to mess with Kubrick.

#3 @jorbin
15 years ago

  • Cc aaron@… added
  • Resolution set to wontfix
  • Status changed from new to closed

With 2010 coming in 3.0 and kubrick being removed as per #10654 , I think it's safe to close this as won't fix.

#4 @dd32
15 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Kubrick needs to continue to be updated to correct bugs and/or update for new usage.

For now, I think kubrick bugs belong on trac still

#5 @nacin
15 years ago

  • Component changed from Themes to WordPress.org
  • Milestone changed from 3.0 to WordPress.org site
  • Owner set to iandstewart
  • Status changed from reopened to assigned

#6 @nacin
15 years ago

  • Component changed from WordPress.org to Themes

#7 @iandstewart
15 years ago

@chrisbliss18 Do you have a screenshot of some of the weirdness?

#8 @iseulde
12 years ago

  • Component changed from Themes to Bundled Theme

#9 @helen
12 years ago

  • Milestone WordPress.org deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

Going to go ahead and close this. Feel free to reopen if it really needs to be.

Note: See TracTickets for help on using tickets.