aligncenter Broken in Visual Editor When Caption Blank

[miqrogroove]

I assume this is a bug in the editor or the admin style sheets. If I upload two images, set them both to align center, and only type a caption for one of them, then the one with the caption will be centered, and the other will be left aligned.

In other words, this works:

[caption align="aligncenter"]<img />[/caption]

This does not work:

<img class="aligncenter" />

The workaround is to click the Preview button, in which case both are aligned center according to my theme.

[miqrogroove]

Workaround two: After inserting the "centered" image with no caption, click the Align Center button, which gives:

<p style="text-align: center;"><img /></p>

[janeforshort]

Punting due to time constraints and lack of patch.

[miqrogroove]

wtf? I thought the purpose of Bug Hunts was to find and fix the bugs?

[miqrogroove]

I'll patch it myself if I have to, just hold your horses.

[azaozz]

This is not a regression but a browser limitation in IE in contentEditable mode. You'll need one of the workarounds there until it's fixed.

[miqrogroove]

I don't understand why this is being put off then? All the patch has to do is match the caption behavior, which is to insert class mceIEcenter in the parent div.

[miqrogroove]

I'm really angry because of the anti-help response I got here. It prevents me from contributing to the project. So I'm going to upload the patch I made on 2.8.4, say to hell with it, and go out for some fresh air. I tested this on IE, FF, Opera, and Chrome. Use it or don't, it wont affect me.

[miqrogroove]

Fixes the aligncenter bug.

[miqrogroove]

Cleaned up the class names. Still not sure where to find the properties editor code.

[azaozz]

It's been a while since I've seen a patch for one of the TinyMCE plugins, thanks. It won't be that easy to properly fix this. The current patch inserts a <div> inside the wrapping <p> and when you switch to the html editor and back it inserts another one inside the <a> tag that is around the image, so it ends up looking pretty bad:

<p><div><a><div><img />...

The align center button adds text-align: center; directly on the wrapping <p> which although not ideal, fixes the annoying IE bug.

[miqrogroove]

I'm definitely a bit lost with the buttons. The patch only works for switching between HTML and Visual view so far. Yes, I suspected there were some invisible tags floating around inside TinyMCE, which I do not have experience with.

Could you suggest some way of making the center button behave just like switching to visual view after setting class=aligncenter? If I can get that to be behave in IE then it should be just a matter of writing fancier regexp to handle linked images.

[miqrogroove]

btw, when I say Center button, I mean the one in the image editor.

[azaozz]

Cannot reproduce this any more, seems fixed in TinyMCE.