WordPress.org

Make WordPress Core

Opened 12 years ago

Closed 6 years ago

#11200 closed enhancement (fixed)

Add count for approved comments filter

Reported by: scribu Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch
Focuses: administration Cc:

Description

On wp-admin/edit-comments.php, Approved is the only filter that doesn't have a count after it.

Attachments (4)

11200.diff (3.1 KB) - added by scribu 12 years ago.
11200.2.diff (7.7 KB) - added by wonderboymusic 6 years ago.
11200.3.diff (12.4 KB) - added by wonderboymusic 6 years ago.
11200.4.diff (10.8 KB) - added by wonderboymusic 6 years ago.

Download all attachments as: .zip

Change History (23)

@scribu
12 years ago

#1 @scribu
12 years ago

Current patch adds the count and updates it dynamically when (un)approving a comment.

However, it doesn't update it for all the other actions: replying, trashing, deleting, marking as spam.

#2 @scribu
12 years ago

  • Cc scribu@… added

#3 @nacin
12 years ago

  • Milestone changed from 3.0 to Future Release

I like this but I think we'll need to account for the other actions if we're to do it.

#4 @ocean90
10 years ago

  • Keywords close added

#17933 has an updated patch.

#5 @scribu
10 years ago

Sure, but it doesn't handle the JS part.

#6 @scribu
10 years ago

  • Keywords needs-refresh added; close removed

#7 @jeremyfelt
8 years ago

  • Component changed from Administration to Comments
  • Focuses administration added

#8 @ocean90
6 years ago

#32016 was marked as a duplicate.

#9 @wonderboymusic
6 years ago

  • Milestone changed from Future Release to 4.4

#10 @wonderboymusic
6 years ago

  • Keywords needs-refresh removed

11200.2.diff adds the count and handles dynamic counts, of which there are many to account for. Still need to handle delete

#11 @wonderboymusic
6 years ago

In 33654:

Comments shouldn't have more than one _wp_trash_meta_status entry. When deleting _wp_trash_meta_status, also delete _wp_trash_meta_time.

See #11200.

#12 @wonderboymusic
6 years ago

In 33655:

Comments List Table:

  • Show count next to "Approved"
  • Properly increment/decrement counts when row actions are clicked
  • In _wp_ajax_delete_comment_response(), return the comment's status with the supplemental data
  • Handle counts properly on each scenario of undo

See #11200.

#13 @wonderboymusic
6 years ago

In 33656:

Comments List Table:

  • Properly increment/decrement approved/pending bubbles in response column

See #11200.

#14 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 33657:

Comments List Table:

  • In a view that initially has comments, but they get removed due to user actions: show the No Items row instead of bombing out and showing nothing (which looks broken)
  • To accomplish this, in WP_Comments_List_Table::display(): call ->display_rows_or_placeholder() instead of ->display()
  • Listen for the end of row .fadeOut()s if necessary using jQuery Promises

Fixes #11200.

#15 @wonderboymusic
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

need to do a few more things here

#16 @wonderboymusic
6 years ago

In 33662:

Comment List Tables:

  • Ensure that dynamic bubble counts are in sync by comment_post_ID
  • Scope :animated to #the-comment-list

See #11200.

#17 @wonderboymusic
6 years ago

In 33663:

After [33662], remove unused var.

See #11200.

#18 @wonderboymusic
6 years ago

In 33692:

Comment List Tables:

  • Toggle visibility of pending bubble when a comment is dynamically moderated
  • Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.

#19 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.