WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 months ago

#11207 accepted defect (bug)

WordPress may display incorrect message when post is saved/published/etc

Reported by: sirzooro Owned by: bsamrajni
Milestone: Future Release Priority: normal
Severity: normal Version: 2.9
Component: Posts, Post Types Keywords: has-patch
Focuses: administration Cc:

Description

When post is saved, WP calls wp_insert_post_data filter. Plugin can use it to change post status. But even post status has been changed via plugin, WP still displays message basing on action originally executed by user. Need to change this and take into account final post status too.

Attachments (2)

11207.diff (437 bytes) - added by blepoxp 4 years ago.
This fixes it for the reported solution.
11207.2.diff (716 bytes) - added by kawauso 3 years ago.

Download all attachments as: .zip

Change History (24)

comment:1 sirzooro4 years ago

Note: I have found this while testing WyPiekacz plugin on WP 2.9. This plugin checks if post submitted for review or published satisfies set of rules, and changes its status to Draft if not. In 2.8 I was able to change displayed message by overwriting $_GET['message'] in admin_notice hook, but this does not work in 2.9 because of changes in wp-admin/edit-form-advanced.php.

comment:2 azaozz4 years ago

  • Keywords reporter-feedback added; needs-patch removed

Have you tried using the filter redirect_post_location?

comment:3 ryan4 years ago

  • Milestone changed from 2.9 to 3.0

comment:4 sirzooro4 years ago

No - this is a new filter added in WP 2.9. I can use it, but this does not fix this problem in general.

comment:5 Denis-de-Bernardy4 years ago

  • Keywords needs-patch added; reporter-feedback removed

comment:6 hakre4 years ago

A potential fix might be to generalize the message displayed sothat it will fit for all cases. How does that sound?

comment:7 hakre4 years ago

Realted: #11515 (and this ticket's content is an intersting use-case to that one)

comment:8 sirzooro4 years ago

I think it should be sufficient to extend statuses list in wp-admin/post.php to include all possible post statuses.

BTW, it may be funny when someone will use wp_insert_post_data filter to trash/untrash post :)

comment:9 bsamrajni4 years ago

  • Owner set to bsamrajni
  • Status changed from new to accepted

comment:10 blepoxp4 years ago

  • Keywords reporter-feedback added; needs-patch removed

The Short: I just tested this on r14235 and it seems to be working well.

The long version (Steps I took to reproduce):

1) Installed said theme
2) Created rule for minimum 1000 words per post
3) Unchecked box to let admin bypass rules
4) Created new post with less than 1000 words
5) Hit publish

Results were that I got the following plugin messages:
1) Post is too short (minimum is 1000 chars, your post has 416).
2) Post Status has been changed to Draft.

And the following WordPress generated message: "Post draft updated. Preview post"

When including more than a 1000 words, I got the default "Publish Posted" message from WordPress. If I then take the number of words below 1000, we go back to the plugin and wordpress messages mentioned above. Everything seems to be working.

comment:11 sirzooro4 years ago

  • Keywords needs-patch added; reporter-feedback removed

@blepoxp: current verwsion of WyPiekacz plugin uses redirect_post_location filter to override target url, so WP displays expected message. Please edit plugin file and disable this filter (comment out line 68) and try again.

comment:12 blepoxp4 years ago

Ok. I see now. BTW, this ticket is referenced in inline documentation for wp_insert_post: http://core.trac.wordpress.org/ticket/9084 It's closed as 'fixed'. Not the same issue or not a real fix?

blepoxp4 years ago

This fixes it for the reported solution.

comment:13 blepoxp4 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

I think the bug only happened when a filter has changed the status from publish to draft. If this is the case, my patch should fix the problem. In a little bit of a rush to change locations right now so I can test more thoroughly later tonight for unintended consequences... i think this should do it though.

comment:14 blepoxp4 years ago

  • Keywords needs-testing removed

I did a little more testing, I think this is the best solution. The code was always taking the final post status into account correctly. The problem was that it also assumed that if $_POST[ 'publish' ] was set, the status would not be draft.

I tested it by placing the following code in twentyten's functions.php and changing the status. It works correctly for all possible stati:

function change_status( $data ) {
	$data['post_status'] = 'publish';
	return $data;
}
add_filter( 'wp_insert_post_data', 'change_status' );

comment:15 nacin4 years ago

  • Milestone changed from 3.0 to 3.1

comment:16 scribu3 years ago

  • Milestone changed from Awaiting Triage to 3.1

comment:17 scribu3 years ago

  • Keywords needs-refresh added

I can't figure out which post.php this patch refers to.

Please read: http://codex.wordpress.org/Reporting_Bugs#Patch_Writing_Guidelines

Also, it probably needs a refresh.

comment:18 nacin3 years ago

  • Milestone changed from 3.1 to Future Release

kawauso3 years ago

comment:19 kawauso3 years ago

  • Keywords needs-refresh removed

comment:20 valeriosza6 months ago

  • Keywords needs-refresh added

comment:21 helen6 months ago

  • Keywords needs-refresh removed

Patch applies fine.

comment:22 nacin3 months ago

  • Component changed from Administration to Posts, Post Types
  • Focuses administration added
Note: See TracTickets for help on using tickets.