Split wp_new_user_notification() into two functions

[sirzooro]

wp_new_user_notification() sends emails to newly registered user and to admin. One of my plugins (​WyPiekacz) redefines it in order to to disable emails sent to admin. Now I want to extend my other plugin (​User Locker) so newly registered users will have to activate theirs accounts by clicking on link sent in email. In order to do this, I have to redefine the same function. I how to do this so both plugins could work at the same time - this is not a problem for me.

However it will be better to allow to redefine only part of wp_new_user_notification() function - either one which sends email to new user, or to admin. Therefore I ask to split this function into two new ones. Attached patch does this.

[nacin]

Why not just add some hooks instead? That function has none currently.

[nacin]

Quick attempt to add hooks to wp_new_user_notification

[nacin]

After going through and adding the hooks, your way seems like a better idea. Figured I'd try it and share anyway.

[westi]

Postponing for now.

[hakre]

I think both Ideas should be combined: split and hooks.

[Denis-de-Bernardy]

combining both ideas gets my vote too.

[jfarthing84]

I like the idea by @nacin. It needs some adjustments, but why introduce new functions when the old one can handle it just fine? I need this same functionality as @sirzooro for my plugin "Theme My Login" as well.

See #12184

[beaulebens]

Any movement on this one? Seems like it'd be a good one to have, especially with people building more and more customized network/multi-site installs. Consider me a +1 to the combined approach as well.

[nacin]

We're done with adding pluggable functions to WordPress. If we are to do this, it should be moving all of these bits out of the pluggable functions, creating two functions that contain proper hooks, and then having the current pluggable function call these new functions. Even better, we should then move that function to pluggable-deprecated.php and use the two new functions wherever we used the old one.

[Denis-de-Bernardy]

Related: #25762

[Denis-de-Bernardy]

introduce two hooks similar to the one suggested in #25762 - 25762.11.diff

[Denis-de-Bernardy]

The same with WP coding standards

[jdgrimes]

Has it been decided not to split this into two functions? I agree with nacin's comment, I think it would be better to split it.

[jfarthing84]

Split wp_new_user_notification into two functions.

[jfarthing84]

My patch creates two new functions: wp_new_user_registration_notification() and wp_new_user_registration_admin_notification(). The current wp_new_user_notification() simply becomes a wrapper function for these two functions. Additionally, I added filters to both functions: one to add the possibility to disable the notification, one to modify the e-mail subject and one to modify the e-mail message.

Ideally, I'd like to see the wp_new_user_notification() call within register_new_user() be replaced with an action, such as new_user_registered, and then the two new functions hooked to it as default actions, rendering wp_new_user_notification() deprecated. However, I know wp_new_user_notification() is used in other places, hence why I didn't propose this route in my patch. This is actually why I added the filters to disable them instead.

[jfarthing84]

Related: #32563.

[jfarthing84]

I would argue that this is resolved with [34251]. The function wasn't split in two, but it's pretty trivial to only send one or the other now.

[johnbillion]

Duplicate of #33587.