PHP Notice while untrashing comment

[sirzooro]

Steps to reproduce:

• create a new comment (if you do not have one);
  
• go to the comments list;
  
• click "Edit";
  
• click "Move to Trash" (you should return to comment list);
  
• click "Undo" to untrash comment.

When you do this, following notice will appear:
Notice: Undefined index: user_ID in C:\wordpress29.local\wp-includes\comment.php on line 1079

Function wp_filter_comment() is called by wp_new_comment() and wp_update_comment(). First function uses user_ID, second user_id. First function calls preprocess_comment filter; second one takes data from DB, where field name is in lowercase.

[sirzooro]

Hmm, seems that the easiest workaround is to just check if you have user_ID or user_id - see attached patch.

[sirzooro]

workaround

[dd32]

IMO, the correct fix here is to kill what ever is setting it to uppercase in the first place if lowercase is expected..

[caesarsgrunt]

I don't get this error...

[sirzooro]

I have confirmed that this warning appears with default theme and no active plugins.

[ryan]

The confusion stems from the $user_ID global. Attached patch defines a $user_id global as well, uses $user_id in wp-comments-post.php, and makes $user_id the preferred variable in wp_filter_comment() and wp_new_comment() with back compat checks for $user_ID.

[sirzooro]

I think it will be good to also add comment(s) which variable version is preferred.

[ryan]

(In [12267]) Standardize on user_id instead of user_ID when passing comment data. fixes #11222

[westi]

This broke setup_userdata() as the argument is the same name as the global.

[westi]

(In [12288]) Restore functionality of setup_userdata() when a user id is supplied. See #11271 and #11222.

[ryan]

(In [12300]) Accept either user_id or user_ID. Remove user_id global. see #11271 #11222