WordPress.org

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#11231 closed defect (bug) (fixed)

Comment lists not consistent when adding a new column

Reported by: arena Owned by:
Milestone: 3.0 Priority: high
Severity: major Version: 2.8.5
Component: Administration Keywords: has-patch tested
Focuses: Cc:

Description

Adding a new column on Comments list

  • works for comments list (pic1.jpg)
  • give a malformed table in post comments list (pic2.jpg)

Attachments (4)

pic1.jpg (180.2 KB) - added by arena 12 years ago.
pic2.jpg (92.9 KB) - added by arena 12 years ago.
Comment_11231.php (717 bytes) - added by arena 12 years ago.
basic plugin for test
#11231.patch (1.4 KB) - added by arena 12 years ago.
patch refresh

Download all attachments as: .zip

Change History (17)

@arena
12 years ago

@arena
12 years ago

#1 @janeforshort
12 years ago

  • Milestone changed from 2.9 to Future Release

We are in beta; things like this will be automatically punted to next release cycle.

This looks like it's being caused by a plugin. Can you provide information on what is causing the display problem?

#2 @arena
12 years ago

What is causing the problem :

  • the comment list can be changed by plugin using following hooks :

add_filter('manage_edit-comments_columns', ... to give the new column(s) name(s)
add_action('manage_comments_custom_column', ... to give the value of this(ose) new column(s)

  • the same comment list in post comments list is a table

the header of the table is hard coded to skip the "In Response To" column and is not using 'manage_edit-comments_columns' hook.
But the content of the table is built using 'manage_comments_custom_column' hook

#3 @arena
12 years ago

  • Milestone changed from Future Release to 2.9.1
  • Priority changed from normal to high
  • Severity changed from normal to major
  • Version changed from 2.8.5 to 2.9

hereattached is the patch that fix the bug

#4 @hakre
12 years ago

  • Keywords has-patch added

This should have been patched in 2.9. Thanks for providing a patch arena, I'll test it, would be nice if you can provide a test-plugin or recommend a plugin to test this.

#5 follow-up: @hakre
12 years ago

I made a first test with no plugins. The docblock of function post_comment_meta_box_thead seems misleading. for me $result is a boolean (false). Your function treats it like an array and the docblock say it's an object. Please verify.

#6 in reply to: ↑ 5 @arena
12 years ago

Replying to hakre:

I made a first test with no plugins. The docblock of function post_comment_meta_box_thead seems misleading. for me $result is a boolean (false). Your function treats it like an array and the docblock say it's an object. Please verify.

@hakre, right. this occurs when the user under admin as no specific option on comments list (no hidden column).

So i update the patch and attach a very basic plugin for test.

@arena
12 years ago

basic plugin for test

#7 @hakre
12 years ago

  • Keywords tested added

Thanks for providing the update and the testcase. I could successfully test it with and without patch. Comments-widget on the post edit screen looks good now with and without the plugin. It does not when the patch is not applied. Looks fixed for me.

#8 @hakre
12 years ago

  • Keywords dev-feedback added

Maybe developer feedback gives this ticket some traction?

#9 @arena
12 years ago

  • Keywords dev-feedback removed
  • Milestone changed from 3.0 to 2.9.2

#10 @arena
12 years ago

  • Milestone changed from 2.9.2 to 3.0

@arena
12 years ago

patch refresh

#11 @arena
12 years ago

  • Version changed from 2.9 to 3.0

#12 @dd32
12 years ago

  • Version changed from 3.0 to 2.8.5

Please leave the Version set to the version in which the bug is reported. This allows for better tracking of bugs.

#13 @dd32
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13775]) Add additional columns to the Posts Comments view. Props arena. Fixes #11231

Note: See TracTickets for help on using tickets.