Comment lists not consistent when adding a new column

[arena]

Adding a new column on Comments list

• works for comments list (pic1.jpg)

• give a malformed table in post comments list (pic2.jpg)

[janeforshort]

We are in beta; things like this will be automatically punted to next release cycle.

This looks like it's being caused by a plugin. Can you provide information on what is causing the display problem?

[arena]

What is causing the problem :

• the comment list can be changed by plugin using following hooks :

add_filter('manage_edit-comments_columns', ... to give the new column(s) name(s)
add_action('manage_comments_custom_column', ... to give the value of this(ose) new column(s)

• the same comment list in post comments list is a table

the header of the table is hard coded to skip the "In Response To" column and is not using 'manage_edit-comments_columns' hook.
But the content of the table is built using 'manage_comments_custom_column' hook

[arena]

hereattached is the patch that fix the bug

[hakre]

This should have been patched in 2.9. Thanks for providing a patch arena, I'll test it, would be nice if you can provide a test-plugin or recommend a plugin to test this.

[hakre]

I made a first test with no plugins. The docblock of function post_comment_meta_box_thead seems misleading. for me $result is a boolean (false). Your function treats it like an array and the docblock say it's an object. Please verify.

[arena]

Replying to hakre:

I made a first test with no plugins. The docblock of function post_comment_meta_box_thead seems misleading. for me $result is a boolean (false). Your function treats it like an array and the docblock say it's an object. Please verify.

@hakre, right. this occurs when the user under admin as no specific option on comments list (no hidden column).

So i update the patch and attach a very basic plugin for test.

[arena]

basic plugin for test

[hakre]

Thanks for providing the update and the testcase. I could successfully test it with and without patch. Comments-widget on the post edit screen looks good now with and without the plugin. It does not when the patch is not applied. Looks fixed for me.

[hakre]

Maybe developer feedback gives this ticket some traction?

[arena]

patch refresh

[dd32]

Please leave the Version set to the version in which the bug is reported. This allows for better tracking of bugs.

[dd32]

(In [13775]) Add additional columns to the Posts Comments view. Props arena. Fixes #11231