WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#11267 closed enhancement (fixed)

Restore original animation of faded message bars

Reported by: nacin Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.9
Component: UI Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

In [11837] (#10021), the fade animation on the admin notices was changed, and it doesn't appear it was intentional.

It is still doing the effect twice, but it used to be just the background color and now its the entire element via opacity.

This started on wp-hackers, http://lists.automattic.com/pipermail/wp-testers/2009-November/012009.html.

Patch attached to revert the changes and rely on background colors instead of opacity. Dev feedback may be helpful if this was intentional.

Attachments (2)

common.dev.js-fade-fix.patch (732 bytes) - added by nacin 6 years ago.
common.dev.js-fade-double-speed.patch (670 bytes) - added by nacin 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 follow-up: @azaozz6 years ago

The reason it was switched to fading is that jQuery doesn't support color animations by default and the plugin needed for this is slowing the loading. Perhaps we can make the fade more subtle, fading to 0.7 or 0.75 instead of 0.5, etc.

Also the color animation was almost invisible on most flat screens (tn panels) as they have deficiencies in showing fine color nuances.

comment:2 in reply to: ↑ 1 @nacin6 years ago

  • Keywords 2nd-opinion added

Replying to azaozz:

The reason it was switched to fading is that jQuery doesn't support color animations by default and the plugin needed for this is slowing the loading.

Right, okay. jquery-color isn't marked as deprecated (as jquery-form), so I didn't catch that.

Perhaps we can make the fade more subtle, fading to 0.7 or 0.75 instead of 0.5, etc.
Also the color animation was almost invisible on most flat screens (tn panels) as they have deficiencies in showing fine color nuances.

Fair enough. I think it needs to be either a little more subtle, or a quicker effect.

I tried out the pulse at twice the speed, still animating between .5 and 1 opacity, and found it more noticeable yet less irritating than the drawn out animation. Patch attached with the values.

comment:3 follow-up: @janeforshort5 years ago

We need to be careful about color fades as cues. Color fades alone won't meet accessibility guidelines, and should only be used as secondary cues.

comment:4 in reply to: ↑ 3 @nacin5 years ago

Replying to janeforshort:

We need to be careful about color fades as cues. Color fades alone won't meet accessibility guidelines, and should only be used as secondary cues.

I agree, and I'm all for improved cues. In this case, a strict color fade was changed to an opacity fade for performance reasons. At this point, I'm just suggesting we speed up the opacity fade to make it more noticeable and also less irritating, otherwise it's a pretty lousy cue.

comment:5 @azaozz5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12380]) Make animation faster for admin notices, props nacin, fixes #11267

comment:6 @janeforshort5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Type changed from defect (bug) to enhancement

I've seen this in action now and the sped-up fade is super distracting, not in a good way. It feels intrusive in a way that the WordPress admin doesn't feel anywhere else. I vote we get rid of the opacity changes altogether and just count on placement and background shading to make it clear that it's an alert message.

comment:7 @azaozz5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Agreed, the faster animation makes it more disruptive. Removing it completely is closer to the original behavior as it was almost unnoticeable.

Fixed in [12385].

Note: See TracTickets for help on using tickets.