WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#11269 closed enhancement (fixed)

Media page jumps after unfolding image details

Reported by: caesarsgrunt Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.9
Component: Media Keywords: has-patch tested commit
Focuses: Cc:

Description

On the Media Library and Gallery pages, when you click Show next to an image, the following happens :

  1. The image details slide down.
  2. The page jumps so that the row for the image in question is at the top of the page.

Step 2 should not happen when the whole image details box fits on the page anyway, as it causes an unnecessary jump.

It should only scroll when it will help the image details to fit on the page better.

Attachments (1)

11269.diff (842 bytes) - added by caesarsgrunt 8 years ago.
Fixes the scrolling issue.

Download all attachments as: .zip

Change History (8)

@caesarsgrunt
8 years ago

Fixes the scrolling issue.

#1 @caesarsgrunt
8 years ago

  • Keywords has-patch commit added; needs-patch removed
  • Milestone changed from Unassigned to 2.9

#2 @scribu
8 years ago

  • Keywords tested added
  • Type changed from defect (bug) to enhancement

Tested in FF 3.5.

#3 @caesarsgrunt
8 years ago

Is anyone going to commit this bugfix?

#4 @scribu
8 years ago

Probably. 2.9 isn't out yet, so there's still hope.

#5 @janeforshort
8 years ago

I've asked Andrew to take a look, but for the record, saying "Tested in FF 3.5" is in no way sufficient to justify a commit. Please rally some community members to test it on additional platforms etc.

#6 @caesarsgrunt
8 years ago

Jane, I know scribu only said he tested it in FF 3.5 - but myself, if I recall correctly, I tested it in Firefox 3.5, Safari 4, Opera 10, and IE 8 before uploading the patch. I do this for most patches to client-side code.

#7 @azaozz
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12349]) Do not auto-scroll the media popup when opening an image details section if it can fit in the viewport, props caesarsgrunt, fixes #11269

Note: See TracTickets for help on using tickets.