WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 2 years ago

Last modified 2 years ago

#11270 closed defect (bug) (fixed)

Punctuation isn't properly internationalised

Reported by: caesarsgrunt Owned by: nbachiyski
Milestone: 3.4 Priority: normal
Severity: normal Version: 2.9
Component: I18N Keywords: has-patch gsoc
Focuses: Cc:

Description

Punctuation should be included in i18n strings, because it is often quite different in foreign languages.

For example, there are several places where exclamation marks are not internationalised.
However, languages such as Spanish also have an exclamation mark at the beginning of the question, whilst there may be languages which do not sue it at all.

An example of this is in wp-admin/comment.php, where the following appears repeatedly :

sprintf(' <a href="%s">'.__('Go back').'</a>!', ...)

Correct alternatives are :

sprintf(' <a href="%s">'.__('Go back!').'</a>', ...)

Or, if you want to keep the punctuation out of the link :

sprintf(__('<a href="%s">Go back</a>!'), ...)

There are other similar i18n punctuation problems scattered throughout WP.

Attachments (1)

11270.diff (1.2 KB) - added by wojtek.szkutnik 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 scribu5 years ago

  • Keywords needs-patch added
  • Milestone changed from Unassigned to Future Release

comment:2 wojtek.szkutnik4 years ago

  • Keywords has-patch gsoc added; needs-patch removed

I went through allof 4093 items containing translations (!!), found only two cases

wojtek.szkutnik4 years ago

comment:3 wojtek.szkutnik4 years ago

  • Cc wojtek.szkutnik@… added

comment:4 ryan3 years ago

I think most of the places where this happens are where we are trying to avoid putting end punctuation within an anchor.

comment:5 nacin2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [19782]:

Kill the exclamation points off an error message for easier translation. props wojtek.szkutnik, fixes #11270.

comment:6 nacin2 years ago

  • Milestone changed from Future Release to 3.4

To emphasize what ryan wrote, we try to avoid putting end punctuation within an anchor. Please re-open if there are any other strings with these problems, so we'll deal with them on a case by case basis.

Note: See TracTickets for help on using tickets.