WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#11278 closed defect (bug) (wontfix)

update_usermeta has still tasks on the open @todo

Reported by: hakre Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.9
Component: General Keywords:
Focuses: Cc:
PR Number:

Description

There is an @todo task left in the file user.php inside the update_usermeta function. Was easy to finish, patch attached.

Should be committed so it can be tested in the wild (I tested it already that it's working).

Attachments (1)

11278.patch (566 bytes) - added by hakre 10 years ago.

Download all attachments as: .zip

Change History (10)

@hakre
10 years ago

#1 @scribu
10 years ago

  • Keywords has-patch added

#2 @janeforshort
10 years ago

@hakre: Can you give some details about the testing you conducted?

#3 @ryan
10 years ago

  • Milestone changed from 2.9 to 3.0

That might need to be stripslashes_deep(). Postponing to 3.0 so we can make some testcases.

#4 @hakre
10 years ago

No need to test because @todo already marked that there was something to fix/remove not to test.

Feel free to write testcases, I might add some as well. Just point to them here.

#5 @hakre
10 years ago

@todo still in code.

#6 @hakre
10 years ago

@todo still in code.

Related: #11720

#7 @Denis-de-Bernardy
10 years ago

  • Keywords needs-unit-tests added; has-patch removed

#8 @nacin
10 years ago

  • Milestone 3.0 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

This function is now deprecated in favor of update_user_meta, which uses the generic metadata API.

#9 @nacin
9 years ago

  • Keywords needs-unit-tests removed
Note: See TracTickets for help on using tickets.