WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#11322 closed defect (bug) (fixed)

Changes needed to schema for new options table keys

Reported by: nacin Owned by: ryan
Milestone: 2.9 Priority: high
Severity: major Version: 2.9
Component: Database Keywords: has-patch
Focuses: Cc:

Description

Looks like dbDelta is attempting to modify the new option_name and autoloaded_options keys. Not a blocker as I first thought -- dbDelta fails silently -- but $wp_queries is invalid in dbDelta's eyes, so it should be changed.

This is due to the very finicky nature of dbDelta, in this case requiring the word "KEY" in addition to "UNIQUE" and not wanting spaces between fields in an index.

Ideally, dbDelta can be improved in the future by preventing such stumbles, particularly with regard to whitespace.

The Codex should probably be updated as well. It currently identifies the two spaces required for primary keys and the need to use KEY over INDEX, but it doesn't mention other whitespace requirements.

Xref: #11266, #10404

Attachments (1)

finicky-dbDelta-options.diff (581 bytes) - added by nacin 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 nacin4 years ago

See also [12217] and #2699.

comment:2 ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.