WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 9 months ago

Last modified 9 months ago

#11344 closed defect (bug) (invalid)

'Show' link doesn't appear for about 10s after 'Crunching' is finished.

Reported by: caesarsgrunt Owned by:
Milestone: Priority: normal
Severity: minor Version: 2.9
Component: Upload Keywords:
Focuses: Cc:

Description

After uploading an image, the 'Show' link doesn't appear for about 10s after 'Crunching' is finished.

Firefox 2.5.5, WP r12320 (but applies to all versions).

Attachments (1)

11344.diff (1.6 KB) - added by solarissmoke 3 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 caesarsgrunt4 years ago

Sorry, Firefox 3.5.5...

comment:2 azaozz4 years ago

'Crunching' is the time when the server makes the image sub-sizes and depends on the image size. There was an idea to make it asynchronous so the next image can be uploaded while sub-sizes are being created but the memory usage would go through the roof.

What we can improve is image_resize(). It can create all sub-sizes in one go without destroying and then loading again the 'big' image for every sub-size.

comment:3 caesarsgrunt4 years ago

Yes, but what I meant was that after the Crunching has finished (the notice has disappeared), there is a longish delay before the "show" link appears for the image.

comment:4 azaozz4 years ago

Don't see this here, perhaps slow/congested Internet connection?

comment:5 caesarsgrunt4 years ago

Nope; I also get it on my local test server. I'll do some investigation at some stage, but I'm very busy at the moment.

comment:6 follow-up: caesarsgrunt4 years ago

Hmm... on my testing server, it actually appears after about 1s in tests I've just done. So I guess it is a slow internet connection as yo say (my internet connection is certainly slow, but it seems to happen at least to some extent when I use faster connections too).

Anyway - once the crunching message is gone, can't the 'show' link appear immediately? What is happening in between 'crunching' being hidden and 'show' being, er, shown?

comment:7 nacin4 years ago

  • Milestone changed from Unassigned to 3.1

comment:8 nacin3 years ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Triage to Future Release

comment:9 in reply to: ↑ 6 solarissmoke3 years ago

  • Keywords has-patch added; needs-patch reporter-feedback removed

Replying to caesarsgrunt:

What is happening in between 'crunching' being hidden and 'show' being, er, shown?

The image data is being loaded asynchronously, and the "Show" link appears once it has loaded - otherwise when you click on it the edit section would not yet be populated...

I think it would be better to leave the "Crunching..." message there until the data is loaded, to avoid that delay. Patch attached. I also noticed some variable duplication which I've remedied.

solarissmoke3 years ago

comment:10 avryl9 months ago

  • Keywords has-patch removed
  • Resolution set to invalid
  • Status changed from new to closed

Media has been redone in 3.5.

comment:11 helen9 months ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.