Don't nofollow links within the site

[caesarsgrunt]

Relative links or links with the site's own domain shouldn't be nofollowed.

This use of nofollow is damaging to the site's search engine rankings.

[caesarsgrunt]

See also #11359 (Don't nofollow links in admin comments)

[caesarsgrunt]

Attached patch (didn't mean to upload it twice...) doesn't add nofollow to links within the site (eg {exapmle.com or /). It does add nofollow to links to other sites (eg google.com), including tricky sites whose domain starts with the siteurl (eg example.com.badsite.com).

[dd32]

didn't mean to upload it twice...

I just deleted 11360.2.diff to keep things straight forward :)

[caesarsgrunt]

Thanks dd32.

I'd quite like some feedback on this patch - is there anything wrong with this approach? If not, it'd be really nice to get it into 2.9... :-)

[hakre]

Some feedback: How to reflect mixed usage of HTTP and HTTPS in that patch? Any Idea?

[caesarsgrunt]

Replying to hakre:

Some feedback: How to reflect mixed usage of HTTP and HTTPS in that patch? Any Idea?

Not sure what you mean... does http/https make any difference in the patch?

[nacin]

Replying to caesarsgrunt:

Replying to hakre:

Some feedback: How to reflect mixed usage of HTTP and HTTPS in that patch? Any Idea?

Not sure what you mean... does http/https make any difference in the patch?

The get_option() call there will only return the ​http:// link, not ​https://. There's a new function home_url() that could be used, but that still wouldn't prevent an ​http:// link from not being picked up on a forced SSL site and vice versa.

At the very least, using home_url() makes sense to make sure the right protocol is searched for. Checking both protocols wouldn't be a bad idea though.

[chriscct7]

This was resolved, in later commits, including #10550

[ocean90]

Replying to chriscct7:

This was resolved, in later commits, including #10550

No, it isn't. #10550 is about reply to links.

[swissspidy]

Needs a new patch using home_url(), perhaps even checking for https and http (using set_url_scheme() maybe?)

[swissspidy]

11360.2.diff​ is a refreshed patch that ensures home_url() gets ignored, no matter if https or http is used.

Also includes unit tests for wp_rel_nofollow()

[swissspidy]

In 36125:

Comments: Don't nofollow links within the site.

Fixes #11360.