"Use as thumbnail" shows up in standalone media browser

[markjaquith]

After uploading an image in the standalone media browser, it showed the "use as thumbnail" link. It shouldn't.

Also, it should be renamed "Use as thumbnail" to "Use as post image" and "Use as page image"

[nacin]

I'm also seeing an E_NOTICE with WP_DEBUG on for wp-admin/includes/media.php:1242. Fixing that solves this. Looks like we need an isset($_GETpost_id?) in there.

[nacin]

Still needs a patch for "Use as thumbnail" to "Use as post image" and "Use as page image."

Will we be changing as many "thumbnail" references as possible for 2.9? A very quick grep puts the number of references to "thumbnail" (PHP, CSS, JS) at 150 more in 2.9 than 2.8.

[nacin]

Patch w/ renaming.

[nacin]

JavaScript still needs to be changed... set-post-thumbnail.js + localization.

[markjaquith]

Thanks for your help nacin. Unfortunately I conflicted your patches with a bunch of my commits. :-\

We're back to "post thumbnail" — "post image" was too vague and general. I have a patch that fixes this issue and a few others around it (like "Use as thumbnail" not showing up when you upload an image).

[markjaquith]

In [12352] — Do not show "Use as thumbnail" in standalone media browser, but DO show it when you upload a new image on a post. fixes #11366

We need to get the post-commit Trac ticket updating code working. Hate having to do this by hand.

[nacin]

Replying to markjaquith:

Thanks for your help nacin. Unfortunately I conflicted your patches with a bunch of my commits. :-\

So I noticed. :-) At least it was the right direction.