display_page_row() generates boat loads of needless queries

[Denis-de-Bernardy]

on sites with many static pages that are spread across multiple parents, display_page_row() triggers multitudes of calls to the db.

specifically, it's repeatedly calling get_pending_comments_num(). it's also calling get_editable_user_ids() and wp_dropdown_users(), both of which do not seem to cache their results in case they're used several times on the same page.

[Denis-de-Bernardy]

a similar problem exists on the edit posts page, with _post_row() and inline_edit_row().

in particular, there are multiple calls to get_tags_to_edit(), in spite of the fact that the latter seem cached towards the beginning of the page.

[Denis-de-Bernardy]

edit media also does huge numbers of calls to get_pending_comments_num()

[nacin]

I think some of this is improved. get_pending_comments_num() still looks not so improved.

[wonderboymusic]

In 34127:

In WP_Media_List_Table, fetch all pending comment counts at once, instead of for each row in the loop.

See #11381.

[wonderboymusic]

get_users() is still missing a cache

[SergeyBiryukov]

In 35222:

In WP_Media_List_Table, rename $pending_count to $comment_pending_count and mark it as protected, for consistency with WP_Posts_List_Table.

See #11381.

[SergeyBiryukov]

In 35223:

In WP_Posts_List_Table, correct the type for $comment_pending_count.

See #11381.

[wonderboymusic]

WP_User_Query needs cache improvements

[pbearne]

Looking at this ticket I can't see what is left to be done
I suspect we can close this