WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#11389 closed defect (bug) (fixed)

is_paged() returns true for first page

Reported by: Denis-de-Bernardy Owned by: ryan
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.9
Component: Query Keywords: has-patch
Focuses: Cc:

Description

domain.com/page/1 is_paged() returns true. the expected result would be false.

Attachments (1)

11389.diff (421 bytes) - added by Denis-de-Bernardy 4 years ago.

Download all attachments as: .zip

Change History (5)

Denis-de-Bernardy4 years ago

comment:1 Denis-de-Bernardy4 years ago

one needs to var_dump() the mess before it gets redirected, in order to notice it.

comment:2 follow-up: ryan4 years ago

I thought we did a canonical redirect for that. Apparently not. Seems like the right fix to me. Anyone out there relying on the old, broken behavior?

comment:3 in reply to: ↑ 2 nacin4 years ago

Replying to ryan:

Anyone out there relying on the old, broken behavior?

I can't imagine so -- a /page/1/ link shouldn't be generated by any template tags; they just work (and don't redirect, though they should).

comment:4 ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12372]) Return false from is_paged() if on the first page. Props Denis-de-Bernardy. fixes #11389

Note: See TracTickets for help on using tickets.