Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#11390 closed defect (bug) (fixed)

Press This entity encoding fix and blank title

Reported by: noel Owned by: azaozz
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.9
Component: Press This Keywords: press this, has-patch
Focuses: Cc:


Allows posts to have an empty title (for P2 and other themes) and fixes entities that were not decoded upon display in the editor.

Attachments (3)

press-this-fix-entities.patch (1.6 KB) - added by noel 6 years ago.
fixes entities and titles
no-&apos.patch (1.5 KB) - added by azaozz 6 years ago.
aposfix-remove.patch (1.6 KB) - added by noel 6 years ago.
Removes aposfix function calls completely.

Download all attachments as: .zip

Change History (15)

@noel6 years ago

fixes entities and titles

comment:1 @lloydbudd6 years ago

  • Milestone changed from Unassigned to 2.9
  • Type changed from task (blessed) to defect (bug)
  • Version set to 2.9

comment:2 @ryan6 years ago

See also #10715

comment:3 @ryan6 years ago

If the post ID is a WP_Error, you can't delete it.

comment:4 @azaozz6 years ago

(In [12371]) Press This empty title fix, props noel, see #11390, fixes #10715

comment:5 @azaozz6 years ago

Not sure about the HTML entities fix. If there's a selection we do stripslashes(), aposfix(), html_entity_decode(), htmlspecialchars() and trim() on it, then we add some <p> and then do html_entity_decode() again (in effect reverting htmlspecialchars)?

@azaozz6 years ago

comment:6 @markjaquith6 years ago

  • Milestone changed from 2.9 to 3.0


comment:7 @hakre6 years ago

  • Keywords reporter-feedback added

Can the original reporter please provide feedback wether or not this is fixed now with the current version?

comment:8 @noel6 years ago

  • Status changed from new to reviewing

original reporter is still testing the patch. :)

comment:9 @Denis-de-Bernardy6 years ago

  • Keywords reporter-feedback removed

@noel6 years ago

Removes aposfix function calls completely.

comment:10 @noel6 years ago

new patch is same as no-&apos patch except it removes erroneous calls to aposfix() function.

comment:11 @noel6 years ago

  • Owner changed from noel to azaozz

comment:12 @azaozz6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In [12592] Fix Press This entity encoding, props noel, fixes #11390

Note: See TracTickets for help on using tickets.