Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#11402 closed defect (bug) (fixed)

Plural for string in Media Library

Reported by: pavelevap Owned by: nbachiyski
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.9
Component: I18N Keywords: has-patch
Focuses: Cc:


String "Media permanently deleted." (wp-admin/upload.php:207) should be prepared for plural in localized versions. You can delete one, two or five media files at once.

Attachments (2)

11402.diff (773 bytes) - added by nacin 6 years ago.
11402.2.diff (3.5 KB) - added by nacin 6 years ago.

Download all attachments as: .zip

Change History (7)

#1 @nacin
6 years ago

  • Keywords has-patch added

Quick patch, but we may be getting ahead of ourselves keeping this consistent across messages for other message strings. Related, #11184. Could be 3.0.

6 years ago

#2 @westi
6 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 2.9 to 3.0

In my tests the $deleted var is only set when you delete a single item and then it is set to 1 for bulk deletes it is not set.

I also don't want another string change now - moving to 3.0 for now.

#3 @nacin
6 years ago

  • Keywords has-patch added; needs-patch removed

New patch. Refactors deleted, trashed, untrashed actions. I imagine more of media will change later in the 3.0 dev cycle but this is a start to bring it in line with how posts etc. are treated.

6 years ago

#4 @hakre
6 years ago

Related: #11515

#5 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13153]) Improve updated messages in Media Library. Add plural strings, add Undo links for trash. Fixes #11402

Note: See TracTickets for help on using tickets.