WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#11404 closed defect (bug) (fixed)

Convert use of _nc() to _nx()

Reported by: nacin Owned by: westi
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.9
Component: I18N Keywords: has-patch early
Focuses: Cc:

Description

_c() was deprecated for _x(). Core still uses _nc() in one spot, however. Patch moves that over to _nx().

Patch also formally deprecates _nc() and moves it to deprecated.php, next to its sibling _c().

I imagine other deprecated moves can be handled in #11388 for 3.0.

Attachments (1)

11404.diff (2.5 KB) - added by nacin 5 years ago.

Download all attachments as: .zip

Change History (3)

@nacin5 years ago

comment:1 @westi5 years ago

  • Keywords early added
  • Milestone changed from 2.9 to 3.0
  • Owner changed from nbachiyski to westi
  • Status changed from new to accepted

I really want to do this.

But not this close to release - really trying to avoid unnecessary string changes.

comment:2 @westi5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [12459]) Deprecate _nc() as _nx() is a much better was of specifying contexts. Fixes #11404 props nacin.

Note: See TracTickets for help on using tickets.