WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#11410 closed feature request (wontfix)

Check whether post has transferred correctly before saving

Reported by: caesarsgrunt Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.9
Component: Editor Keywords: needs-patch
Focuses: Cc:

Description

I often save a post, and find that only half of the post has been transferred and saved. This is undoubtedly due to my incredibly slow internet connection, but it is still extremely frustrating when I loose a whole load of changes by having to revert to the last revision to get the rest of my post back. And of course if it's the first time I've saved it, I have to start from scratch. (Yes, I should save more often, but (a) I get more useless revisions and (b) it takes soooo long on my connection...)

Proposed solution:
Before saving, create an md5 hash of the post using JavaScript. Submit this with the post, and compare it to the md5 hash of the received data before saving.

Change History (5)

comment:1 Denis-de-Bernardy5 years ago

Proposed additional solution: decrease the huge number of queries that occur when saving a post.

comment:2 in reply to: ↑ description ; follow-up: hakre5 years ago

Replying to caesarsgrunt:

only half of the post has been transferred and saved.

Can you specify this more? Could it be the case the the full post is transfered but saving it does only save the half?

comment:3 in reply to: ↑ 2 Denis-de-Bernardy5 years ago

  • Severity changed from major to normal

Replying to hakre:

Replying to caesarsgrunt:

only half of the post has been transferred and saved.

Could it be the case the the full post is transfered but saving it does only save the half?

I've seen this occur too behind very bad network connections. As far as I could tell, the POST request would start, but it failed to fully send the data. It would occasionally be missing more information (I can't recall the specifics, but think page template, menu order, status, etc.), too.

comment:4 hakre5 years ago

That would mean we should add a checksum. CRC32 or MD5 could do the job for a starter. JS implementations for those should be available and we could use some client-code to provide that feature.

I have no Idea for a non-javascript fallback.

comment:5 dd324 years ago

  • Milestone 3.0 deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Type changed from defect (bug) to feature request

I have no Idea for a non-javascript fallback.

No such thing would exist for whats being described here.

The HTTP POST to the server should fail and PHP never be informed of a failed transmission.

I dont see how a checksum is going to help this, TCP has checksums built in as well, so its basically down to the browser not sending complete data, If its failed to read the entire post content, chances are, it'll just checksum the part it has read, and everything will succeed still, just with an added checksum that didnt do anything.

I'm closing as wontfix, Its so out there, that if a plugin wanted to do it, I'm sure they could.

Note: See TracTickets for help on using tickets.