user_nicename should get memcached

[Denis-de-Bernardy]

When displaying an author's page, there are queries:

SELECT ID FROM users WHERE user_nicename='whoever'

SELECT display_name FROM users WHERE user_nicename = 'whoever'

the second one could be avoided with a non-persistent cache bucket indexed on user_nicename. we could store the user_id, for instance.

both of them could be avoided with the same bucket if the latter is made persistent.

[Denis-de-Bernardy]

actually, it does get memcached:

wp_cache_add($user->user_nicename, $user->ID, 'userslugs');

so we should use it in WP query and for the display_name.

[hakre]

I did not look into the code but couldn't both values (ID, display_name) selected with one query? Wouldn't that solve the job as well?

[hakre]

something like merging

SELECT ID FROM users WHERE user_nicename='whoever'

SELECT display_name FROM users WHERE user_nicename = 'whoever'

into

SELECT ID, display_name FROM users WHERE user_nicename = 'whoever'

[nacin]

Replying to hakre:

something like merging
SELECT ID FROM users WHERE user_nicename='whoever'
SELECT display_name FROM users WHERE user_nicename = 'whoever'
into
SELECT ID, display_name FROM users WHERE user_nicename = 'whoever'

Those queries are in separate files.

[Denis-de-Bernardy]

not sure what you guys are discussing... the suggested patch strips the two queries already with memcached enabled. :-)

[hakre]

My fault, I thought they both are more close to each other.

[Denis-de-Bernardy]

this has been used on a live site for months.

[nacin]

Due to [14160]

[xibe]

Refreshed patch.

[ocean90]

From general-template.php:

	// If there's an author
	if ( is_author() ) {
		$author = get_queried_object();
		$title = $author->display_name;
	}

get_queried_object() calls get_userdata() which calls get_user_by(). get_user_by() does the caching, see [10992].

[SergeyBiryukov]

Fixed in [15598].